Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teach forder to re-use existing key and index attributes instead of sorting from scratch #4386

Merged
merged 62 commits into from
Jul 28, 2024
Merged

Teach forder to re-use existing key and index attributes instead of sorting from scratch #4386

merged 62 commits into from
Jul 28, 2024

Commits on Apr 18, 2020

  1. lazy forder

    @jangorecki
    jangorecki committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    b0efcf5 View commit details
    Browse the repository at this point in the history

  2. fix tests

    @jangorecki
    jangorecki committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    aaead65 View commit details
    Browse the repository at this point in the history

  3. fix tests

    @jangorecki
    jangorecki committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    b0858df View commit details
    Browse the repository at this point in the history

  4. respect use.index option

    @jangorecki
    jangorecki committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    9df2668 View commit details
    Browse the repository at this point in the history

  5. bmerge timings

    @jangorecki
    jangorecki committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    62982ed View commit details
    Browse the repository at this point in the history

  6. codecov

    @jangorecki
    jangorecki committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    eec4971 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2020

  1. helper function

    @jangorecki
    jangorecki committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    9affbfa View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. reduce diff to master

    @jangorecki
    jangorecki committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    b36136a View commit details
    Browse the repository at this point in the history

  2. rename fix

    @jangorecki
    jangorecki committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    3442b78 View commit details
    Browse the repository at this point in the history

  3. setindex writes groups (retGrp=TRUE) 

    forder C set index directly
smart opt for index retGrp=T/F
no tests updated yet
    @jangorecki
    jangorecki committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    dfe883e View commit details
    Browse the repository at this point in the history

  4. calc order, not groups

    @jangorecki
    jangorecki committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    efb3319 View commit details
    Browse the repository at this point in the history

  5. expect to reach optimization

    @jangorecki
    jangorecki committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    68b378d View commit details
    Browse the repository at this point in the history

  6. skip opt for list

    @jangorecki
    jangorecki committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    0bd0e1e View commit details
    Browse the repository at this point in the history

  7. override retGrp=F by retGrp=T is legit use

    @jangorecki
    jangorecki committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    71f5aeb View commit details
    Browse the repository at this point in the history

  8. more backward compatiblility, no retGrp from getindex

    @jangorecki
    jangorecki committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    de916aa View commit details
    Browse the repository at this point in the history

  9. more verbose messages during opts in forderLazy

    @jangorecki
    jangorecki committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    0a3da1d View commit details
    Browse the repository at this point in the history

  10. recycle order 1/-1 argument in one place

    @jangorecki
    jangorecki committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    068c1a9 View commit details
    Browse the repository at this point in the history

  11. precise verbose messages

    @jangorecki
    jangorecki committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    326695d View commit details
    Browse the repository at this point in the history

  12. recycle arg once _by_ arg is known

    @jangorecki
    jangorecki committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    8be2d53 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. copy paste typo fix

    @jangorecki
    jangorecki committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    3383bbf View commit details
    Browse the repository at this point in the history

  2. forder writing index disabled

    @jangorecki
    jangorecki committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    cc7a2b6 View commit details
    Browse the repository at this point in the history

  3. fix tests

    @jangorecki
    jangorecki committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    514913a View commit details
    Browse the repository at this point in the history

  4. code coverage

    @jangorecki
    jangorecki committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    ca2823d View commit details
    Browse the repository at this point in the history

  5. minor update for safer use of internal option

    @jangorecki
    jangorecki committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    4e9bbb3 View commit details
    Browse the repository at this point in the history

  6. fix bad name in unit test

    @jangorecki
    jangorecki committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    4d0dec3 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. retGrp=F requires downgrade idx and it seems to be costly

    @jangorecki
    jangorecki committed May 8, 2020
    Configuration menu
    Copy the full SHA
    1606046 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. NA stats from forder

    @jangorecki
    jangorecki committed May 20, 2020
    Configuration menu
    Copy the full SHA
    a9b01ff View commit details
    Browse the repository at this point in the history

  2. keyOpt fix, and existing tests

    @jangorecki
    jangorecki committed May 20, 2020
    Configuration menu
    Copy the full SHA
    ded1e1a View commit details
    Browse the repository at this point in the history

  3. fixes for na.last in key and setting idx

    @jangorecki
    jangorecki committed May 20, 2020
    Configuration menu
    Copy the full SHA
    53cce98 View commit details
    Browse the repository at this point in the history

  4. filling tests for na.last=T and possible fixes

    @jangorecki
    jangorecki committed May 20, 2020
    Configuration menu
    Copy the full SHA
    1e92366 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2020

  1. more stats, any non ascii utf8

    @jangorecki
    jangorecki committed May 21, 2020
    Configuration menu
    Copy the full SHA
    0f95e6f View commit details
    Browse the repository at this point in the history

  2. better naming of new stats attributes

    @jangorecki
    jangorecki committed May 21, 2020
    Configuration menu
    Copy the full SHA
    bbe1d03 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. add extra escape to escape IS_ASCII checks

    @jangorecki
    jangorecki committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    91437de View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into lazy-forder

    @jangorecki
    jangorecki committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    5239c3f View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Merge branch 'master' into lazy-forder

    @mattdowle
    mattdowle authored Jan 5, 2021
    Configuration menu
    Copy the full SHA
    0f6b15a View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Merge branch 'master' into lazy-forder

    @jangorecki
    jangorecki committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    14e9168 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Merge branch 'master' into lazy-forder

    @MichaelChirico
    MichaelChirico committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    8bf5b5c View commit details
    Browse the repository at this point in the history

  2. update test number after merge

    @MichaelChirico
    MichaelChirico committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    0f15775 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Merge branch 'master' into lazy-forder

    @MichaelChirico
    MichaelChirico committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e2710b8 View commit details
    Browse the repository at this point in the history

  2. apply minor review feedback

    @MichaelChirico
    MichaelChirico committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c8f5b7e View commit details
    Browse the repository at this point in the history

  3. More minor review feedback

    @MichaelChirico
    MichaelChirico committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    92a97d1 View commit details
    Browse the repository at this point in the history

  4. use options= to set options

    @MichaelChirico
    MichaelChirico committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c2ae34a View commit details
    Browse the repository at this point in the history

  5. more feedback

    @MichaelChirico
    MichaelChirico committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    4184fe9 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Rename forderLazy->forderMaybePresorted

    @MichaelChirico
    MichaelChirico authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    0588d4d View commit details
    Browse the repository at this point in the history

  2. UNPROTECT() more aggressively

    @MichaelChirico
    MichaelChirico authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    8b3a80a View commit details
    Browse the repository at this point in the history

  3. maybe_reset_index() helper

    @MichaelChirico
    MichaelChirico authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    497a08f View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge remote-tracking branch 'origin/master' into lazy-forder

    @MichaelChirico
    MichaelChirico committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    b948345 View commit details
    Browse the repository at this point in the history

  2. Strict prototyping (-Wstrict-prototypes)

    @MichaelChirico
    MichaelChirico committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    3e898e9 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/lazy-forder' into lazy-forder

    @MichaelChirico
    MichaelChirico committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    d8e0ea7 View commit details
    Browse the repository at this point in the history

  4. fix sloppy refactor for maybe_reset_index()

    @MichaelChirico
    MichaelChirico committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    d8adf3c View commit details
    Browse the repository at this point in the history

  5. Fix implicit reliance on datatable.optimize

    @MichaelChirico
    MichaelChirico committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    1d398aa View commit details
    Browse the repository at this point in the history

  6. Fix elsewhere, and encapsulate the logic inside a test()

    @MichaelChirico
    MichaelChirico committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    ac19b83 View commit details
    Browse the repository at this point in the history

  7. style

    @MichaelChirico
    MichaelChirico committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    9675f06 View commit details
    Browse the repository at this point in the history

  8. spurious whitespace change

    @MichaelChirico
    MichaelChirico committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    e8b9dcd View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. NEWS entry for lazy forder

    @jangorecki
    jangorecki committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    a48ff5e View commit details
    Browse the repository at this point in the history

  2. tidy up NEWS

    @MichaelChirico
    MichaelChirico authored Jul 21, 2024
    Configuration menu
    Copy the full SHA
    59f5f21 View commit details
    Browse the repository at this point in the history

  3. PROTECT() on key attribute

    @MichaelChirico
    MichaelChirico authored Jul 21, 2024
    Configuration menu
    Copy the full SHA
    32c6305 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Merge branch 'master' into lazy-forder

    @MichaelChirico
    MichaelChirico committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    050e048 View commit details
    Browse the repository at this point in the history

  2. rename arg/option 'lazy' -> 'reuseSorting'

    @MichaelChirico
    MichaelChirico committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    02ff718 View commit details
    Browse the repository at this point in the history

  3. MaybeSorted->ReuseSorting

    @MichaelChirico
    MichaelChirico committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    320f496 View commit details
    Browse the repository at this point in the history

  4. other lazy= usage

    @MichaelChirico
    MichaelChirico committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    799b4a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Merge branch 'master' into lazy-forder

    @MichaelChirico
    MichaelChirico authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    ffe431f View commit details
    Browse the repository at this point in the history