Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the way coercion happens for list columns in rbindlist #6353

Open
MichaelChirico opened this issue Aug 5, 2024 · 1 comment
Open

Simplify the way coercion happens for list columns in rbindlist #6353

MichaelChirico opened this issue Aug 5, 2024 · 1 comment

Comments

@MichaelChirico
Copy link
Member 

          AFAIU #6263 our pattern with `listprotect`, `PROTECT` and `UNPROTECT` inside the if cannot be checked with rchk.

However, we need this pattern because of the protection stack size(see #5448).

WDYT should we try to use a PROTECT_WITH_INDEX instead?

Originally posted by @ben-schwen in #6311 (review)

This region is quite complicated & causing headaches for rchk. I think we would do well to refactor it for simplicity.
@MichaelChirico MichaelChirico mentioned this issue Aug 5, 2024
Merged
@MichaelChirico
Copy link
Member Author

Ref also Tomas' helpful comments: #6263 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MichaelChirico