Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CI check for translation quality #5683

Closed
MichaelChirico opened this issue Sep 4, 2023 · 4 comments
Closed

Add a CI check for translation quality #5683

MichaelChirico opened this issue Sep 4, 2023 · 4 comments
Labels
ci translation issues/PRs related to message translation projects

Comments

@MichaelChirico
Copy link
Member

To prevent regression on #5681. It will be easy enough, but waiting to invest while our CI is still broken at HEAD.

@MichaelChirico MichaelChirico added ci translation issues/PRs related to message translation projects labels Sep 4, 2023
@jangorecki
Copy link
Member

How does the check looks like? We could either keep it in ghcl where we check for codecov or in glci where we keep r cmd checks

@MichaelChirico
Copy link
Member Author

It's open-ended (we can start building out quality checks), but to start with, just running tools::checkPoFiles().

@tdhock
Copy link
Member

tdhock commented Aug 15, 2024

hi @MichaelChirico can this be closed now that #6358 is merged?

@MichaelChirico
Copy link
Member Author

Indeed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci translation issues/PRs related to message translation projects
Projects
None yet
Development

No branches or pull requests

3 participants