From c7e412c2917ad93bfb1bde06ee8de547695be10f Mon Sep 17 00:00:00 2001 From: Ani Date: Sat, 21 Sep 2024 04:45:00 -0700 Subject: [PATCH] Added an atime test for performance improvement in transform() brought by #5493 (#6515) --- .ci/atime/tests.R | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index 0420130ce..82fa82fc4 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -166,5 +166,16 @@ test.list <- atime::atime_test_list( Slow = "a01f00f7438daf4612280d6886e6929fa8c8f76e", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/fc0c1e76408c34a8482f16f7421d262c7f1bde32) in the PR (https://github.com/Rdatatable/data.table/pull/6296/commits) that fixes the issue Fast = "f248bbe6d1204dfc8def62328788eaadcc8e17a1"), # Merge commit of the PR (https://github.com/Rdatatable/data.table/pull/6296) that fixes the issue + # Issue mentioned and fixed in: https://github.com/Rdatatable/data.table/pull/5493 + "transform improved in #5493" = atime::atime_test( + N = 10^seq(1, 7), + setup = { + df <- data.frame(x = runif(N)) + dt <- as.data.table(df) + }, + expr = data.table:::transform.data.table(dt, y = round(x)), + Slow = "0895fa247afcf6b38044bd5f56c0d209691ddb31", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/93ce3ce1373bf733ebd2036e2883d2ffe377ab58) in the PR (https://github.com/Rdatatable/data.table/pull/5493/commits) that fixes the issue + Fast = "2d1a0575f87cc50e90f64825c30d7a6cb6b05dd7"), # Merge commit of the PR (https://github.com/Rdatatable/data.table/pull/5493) that fixes the issue + NULL) # nolint end: undesirable_operator_linter.