Skip to content

Commit

Permalink
Merge branch 'master' into dcast-warn-length-not-1
Browse files Browse the repository at this point in the history
  • Loading branch information
tdhock authored Aug 1, 2024
2 parents f19c0f0 + c36c84f commit 366e77e
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
3 changes: 3 additions & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,6 @@
^lib$
^library$
^devwd$

# only the inst/po compressed files are needed, not raw .pot/.po
^po$
4 changes: 3 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@

## NOTES

24. `dcast()` docs have always required aggregation function to return a single value, and previously dcast would error if vector with length!=1 was returned (only when fill=NULL). Now dcast will no longer error, but will warn that this is undefined behavior, even when fill is not NULL, [#6032](https://github.com/Rdatatable/data.table/issues/6032). In particular, this will warn for fun.aggregate=identity, which was observed in several revdeps. We may change this back to an error in a future release, so revdeps should fix their code as soon as possible. Thanks to Toby Dylan Hocking for the PR, and Michael Chirico for analysis of GitHub revdeps.

1. `transform` method for data.table sped up substantially when creating new columns on large tables. Thanks to @OfekShilon for the report and PR. The implemented solution was proposed by @ColeMiller1.

2. The documentation for the `fill` argument in `rbind()` and `rbindlist()` now notes the expected behaviour for missing `list` columns when `fill=TRUE`, namely to use `NULL` (not `NA`), [#4198](https://github.com/Rdatatable/data.table/pull/4198). Thanks @sritchie73 for the proposal and fix.
Expand Down Expand Up @@ -184,7 +186,7 @@ This feature resolves [#4387](https://github.com/Rdatatable/data.table/issues/43

23. `set()` now adds new columns even if no rows are updated, [#5409](https://github.com/Rdatatable/data.table/issues/5409). This behavior is now consistent with `:=`, thanks to @mb706 for the report and @joshhwuu for the fix.

24. `dcast()` docs have always required aggregation function to return a single value, and previously dcast would error if vector with length!=1 was returned (only when fill=NULL). Now dcast will no longer error, but will warn that this is undefined behavior, even when fill is not NULL, [#6032](https://github.com/Rdatatable/data.table/issues/6032). In particular, this will warn for fun.aggregate=identity, which was observed in several revdeps. We may change this back to an error in a future release, so revdeps should fix their code as soon as possible. Thanks to Toby Dylan Hocking for the PR, and Michael Chirico for analysis of GitHub revdeps.
24. The internal `init()` function in `fread.c` module has been marked as `static`, [#6328](https://github.com/Rdatatable/data.table/pull/6328). This is to avoid name collisions, and the resulting segfaults, with other libraries that might expose the same symbol name, and be already loaded by the R process. This was observed in Cray HPE environments where the `libsci` library providing LAPACK to R already has an `init` symbol. Thanks to @rtobar for the report and fix.

## TRANSLATIONS

Expand Down
4 changes: 2 additions & 2 deletions po/R-pt_BR.po
Original file line number Diff line number Diff line change
Expand Up @@ -2771,10 +2771,10 @@ msgid ""
"**********"
msgstr ""
"**********\n"
"Executando data.table em inglês; o suporte ao pacote está disponível apenas "
"Executando data.table em português; o suporte ao pacote está disponível apenas "
"em inglês. Ao procurar ajuda online, certifique-se de verificar também a "
"mensagem de erro em inglês. Isso pode ser obtido examinando os arquivos po/R-"
"<locale>.po e po/<locale>.po no código-fonte do pacote, onde as mensagens de "
"pt_BR.po e po/pt_BR.po no código-fonte do pacote, onde as mensagens de "
"erro no idioma nativo e em inglês podem ser encontradas lado a lado.\n"
"**********"

Expand Down
2 changes: 1 addition & 1 deletion src/fread.c
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ static double NAND;
static double INFD;

// NAN and INFINITY constants are float, so cast to double once up front.
void init(void) {
static void init(void) {
NAND = (double)NAN;
INFD = (double)INFINITY;
}
Expand Down

0 comments on commit 366e77e

Please sign in to comment.