-
Notifications
You must be signed in to change notification settings - Fork 978
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Message fixes for the C code (#6504)
* Expand the fragmented sentence Otherwise it's very hard to translate without pgettext() in a language where "there is no <x>" is translated as "<x> is absent" * Combine the fragmented sentence This will avoid potential word order issues. * Correct internal error message .Last.value is a variable in the global environment. .Last.updated belongs to the data.table package. * data.table-help -> data.table issue tracker * Avoid templating on the known value of a variable * When '9'+1 != ':', say it's ASCII-incompatible * Don't check for length(.) < 0 * Use R capitalization for logical constants * newline->error for codecov * Use internal_error() instead of manual error handling Co-authored-by: Michael Chirico <chiricom@google.com> * internal_error needs __func__ * Branch a previously templated translation * Combine a fragmented sentence * Recombine "gather took %.3fs\n" Co-authored-by: rikivillalba <32423469+rikivillalba@users.noreply.github.com> * Split off the shrinkMSB helper Hopefully the compiler will be smart enough to inline it back. Co-authored-by: Michael Chirico <chiricom@google.com> * Branch a fragmented verbose sentence in fread * Don't say we reduced MSBsize if it didn't change Forgot to take #6504 (comment) into account. * declaration style for pointer spacing * line bump for codecov + readability --------- Co-authored-by: Michael Chirico <chiricom@google.com> Co-authored-by: rikivillalba <32423469+rikivillalba@users.noreply.github.com>
- Loading branch information
1 parent
1c771e5
commit 0e257a8
Showing
5 changed files
with
36 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters