Integration: Save / Login functionality not as expected #1162
+38
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![create-issue-branch[bot]](https://avatars.githubusercontent.com/in/36017?s=60&v=4){kind=small}
danhalson
had a problem deploying
to
previews/1162/merge
GitHub Actions
Failure
danhalson
had a problem deploying
to
previews/1162/merge
GitHub Actions
Failure
danhalson
had a problem deploying
to
previews/1162/merge
GitHub Actions
Failure
conorriches
reviewed
Jan 28, 2025
| @@ -42,17 +42,26 @@ export const useProjectPersistence = ({ | |||
| const accessToken = user?.access_token; | |||
| const params = { reactAppApiEndpoint, accessToken }; | |||
|
|
|||
| if (saveTriggered) { | |||
| if (saveTriggered || localStorage.getItem("awaitingSave")) { | |||
There was a problem hiding this comment.
This looks great, where is awaitingSave set?
There was a problem hiding this comment.
it's set in standalone, when the login to save button is clicked - there's an incoming PR for that
There was a problem hiding this comment.
ah roger! I shall press the happy green button of joy!
danhalson
had a problem deploying
to
previews/1162/merge
GitHub Actions
Failure
danhalson
had a problem deploying
to
previews/1162/merge
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Login to save' button now automatically saves after logging in.
Closes #843