From 5d0c69caf145ffe5a9587ac2851a720b3a405f83 Mon Sep 17 00:00:00 2001 From: Dan Halson Date: Wed, 29 Jan 2025 09:13:22 +0000 Subject: [PATCH] Try pinning previous ubuntu version to avoid cloudflare issue (#1178) Test deployment to try out a potential workaround for cloudflare issue: ``` Update - We are continuing to work on a fix for native CRC32 checksum handling in R2 APIs. If you run into an issue, please see the documentation for workarounds based on the SDK that you are using: https://developers.cloudflare.com/r2/examples/aws/ Jan 22, 2025 - 16:33 UTC Update - We are continuing to work on a fix for this issue. Jan 17, 2025 - 11:23 UTC Identified - AWS recently updated their SDKs to enable CRC32 checksums on multiple object operations by default. R2 does not currently support CRC32 checksums, and the default configurations will return header related errors such as Header 'x-amz-checksum-algorithm' with value 'CRC32' not implemented. Impacted users can either pin AWS SDKs to a prior version or modify the configuration to restore the prior default behavior of not checking checksums on upload. For more details, see the examples section of the R2 Docs for the relevant SDK: https://developers.cloudflare.com/r2/examples/aws/ Jan 17, 2025 - 03:20 UTC ``` --------- Co-authored-by: Conor --- .github/workflows/changelog.yml | 34 ++++++++++++++++----------------- .github/workflows/deploy.yml | 6 ++++++ CHANGELOG.md | 4 ++++ 3 files changed, 27 insertions(+), 17 deletions(-) diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml index 82567be5c..6f34a5ca5 100644 --- a/.github/workflows/changelog.yml +++ b/.github/workflows/changelog.yml @@ -3,26 +3,26 @@ name: Changelog on: pull_request: branches: - - '**' + - "**" jobs: changelog-updated: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 - with: - fetch-depth: 0 - - name: Check if changelog updated - id: changed-files-specific - uses: tj-actions/changed-files@v29.0.4 - with: - base_sha: ${{ github.event.pull_request.base.sha }} - files: | - CHANGELOG.md - env: - GITHUB_TOKEN: ${{ github.token }} + - uses: actions/checkout@v4 + with: + fetch-depth: 0 + - name: Check if changelog updated + id: changed-files-specific + uses: tj-actions/changed-files@v29.0.4 + with: + base_sha: ${{ github.event.pull_request.base.sha }} + files: | + CHANGELOG.md + env: + GITHUB_TOKEN: ${{ github.token }} - - name: Fail job if changelog not updated - if: steps.changed-files-specific.outputs.any_changed == 'false' - run: | - exit 1 + - name: Fail job if changelog not updated + if: steps.changed-files-specific.outputs.any_changed == 'false' + run: | + exit 1 diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index de3b9fe93..db09ef1b3 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -123,6 +123,12 @@ jobs: env: NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - name: Install AWS CLI v2.22.35 + run: | + curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64-2.22.35.zip" -o "awscliv2.zip" + unzip awscliv2.zip + sudo ./aws/install --update + - name: Build WC bundle run: | # TODO: Reinitialise when storybook build is fixed diff --git a/CHANGELOG.md b/CHANGELOG.md index 6795ef2bb..43cbee96f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), ## Unreleased +### Fixed + +- Fix AWS CLI in deploy script to 2.22.35 to workaround cloudflare issue (See https://developers.cloudflare.com/r2/examples/aws/aws-cli/) (#1158) + ### Added - Ability to write to files in `python` (#1146)