Skip to content

Commit

Permalink
Try pinning previous ubuntu version to avoid cloudflare issue (#1178)
Browse files Browse the repository at this point in the history
Test deployment to try out a potential workaround for cloudflare issue:

```
Update - We are continuing to work on a fix for native CRC32 checksum handling in R2 APIs. If you run into an issue, please see the documentation for workarounds based on the SDK that you are using: https://developers.cloudflare.com/r2/examples/aws/
Jan 22, 2025 - 16:33 UTC
Update - We are continuing to work on a fix for this issue.
Jan 17, 2025 - 11:23 UTC
Identified - AWS recently updated their SDKs to enable CRC32 checksums on multiple object operations by default. 
R2 does not currently support CRC32 checksums, and the default configurations will return header related errors such as Header 'x-amz-checksum-algorithm' with value 'CRC32' not implemented. 

Impacted users can either pin AWS SDKs to a prior version or modify the configuration to restore the prior default behavior of not checking checksums on upload. 

For more details, see the examples section of the R2 Docs for the relevant SDK: 
https://developers.cloudflare.com/r2/examples/aws/
Jan 17, 2025 - 03:20 UTC
```

---------

Co-authored-by: Conor <conor.riches@raspberrypi.org>
  • Loading branch information
danhalson and conorriches authored Jan 29, 2025
1 parent 1eae407 commit 5d0c69c
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 17 deletions.
34 changes: 17 additions & 17 deletions .github/workflows/changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,26 +3,26 @@ name: Changelog
on:
pull_request:
branches:
- '**'
- "**"

jobs:
changelog-updated:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Check if changelog updated
id: changed-files-specific
uses: tj-actions/changed-files@v29.0.4
with:
base_sha: ${{ github.event.pull_request.base.sha }}
files: |
CHANGELOG.md
env:
GITHUB_TOKEN: ${{ github.token }}
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Check if changelog updated
id: changed-files-specific
uses: tj-actions/changed-files@v29.0.4
with:
base_sha: ${{ github.event.pull_request.base.sha }}
files: |
CHANGELOG.md
env:
GITHUB_TOKEN: ${{ github.token }}

- name: Fail job if changelog not updated
if: steps.changed-files-specific.outputs.any_changed == 'false'
run: |
exit 1
- name: Fail job if changelog not updated
if: steps.changed-files-specific.outputs.any_changed == 'false'
run: |
exit 1
6 changes: 6 additions & 0 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,12 @@ jobs:
env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Install AWS CLI v2.22.35
run: |
curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64-2.22.35.zip" -o "awscliv2.zip"
unzip awscliv2.zip
sudo ./aws/install --update
- name: Build WC bundle
run: |
# TODO: Reinitialise when storybook build is fixed
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## Unreleased

### Fixed

- Fix AWS CLI in deploy script to 2.22.35 to workaround cloudflare issue (See https://developers.cloudflare.com/r2/examples/aws/aws-cli/) (#1158)

### Added

- Ability to write to files in `python` (#1146)
Expand Down

0 comments on commit 5d0c69c

Please sign in to comment.