Merge pull request #135 from RaenonX-DL/dev

v2.7.0 Release

.codacy.yml

@@ -4,7 +4,3 @@ engines:
     exclude_paths:
       # Test files
       - "**.test.ts"
-  csslint:
-    exclude_paths:
-      # Bootstrap CSS file (auto-generated)
-      - "src/bootstrap.css"

.github/workflows/app.yml

@@ -3,6 +3,7 @@ name: Node CI
 on: [ push ]
 
 env:
+  # Need to use real backends for cypress testings
   NEXT_PUBLIC_API_ROOT: https://dl-back.raenonx.cc
   NEXT_PUBLIC_RESOURCE_ROOT: https://raw.githubusercontent.com/RaenonX-DL/dragalia-site-resources/main
   NEXT_PUBLIC_DEPOT_ROOT: https://raw.githubusercontent.com/RaenonX-DL/dragalia-data-depot/main
@@ -49,10 +50,13 @@ jobs:
       - name: npm run lint
         run: npm run lint
 
+      - name: npm run lint
+        run: npm run lint:css
+
       - name: npm test
         run: npm run test -- --coverage
 
-      - name: Send Coverage report
+      - name: Send coverage report
         uses: codacy/codacy-coverage-reporter-action@master
         with:
           project-token: ${{ secrets.CODACY_PROJECT_TOKEN }}
@@ -68,14 +72,8 @@ jobs:
       PORT: 3000
 
     strategy:
-      # DO NOT cancel the others if any test failed
-      # https://github.com/cypress-io/github-action/issues/48
-      fail-fast: false
       matrix:
         node-version: [ 14.x ]
-        browser: [ chrome, firefox ]
-        # Run 3 cypress copies in parallel
-        containers: [ 1, 2 ]
 
     steps:
       - uses: actions/checkout@v2
@@ -87,21 +85,39 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
 
-      - name: cypress tests
-        uses: cypress-io/github-action@v2
+      - name: Cache node modules
+        uses: actions/cache@v2
+        env:
+          cache-name: cache-node-modules
         with:
-          build: npm run build
-          start: npm run start
-          # Configs
-          browser: ${{ matrix.browser }}
-          record: true
-          parallel: true
-          group: Cypress - ${{ matrix.browser }}
-          cache-key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
-          # Boot
-          wait-on: 'http://localhost:3000'
+          # npm cache files are stored in `~/.npm` on Linux/macOS
+          # https://github.com/npm/cli/issues/564#issuecomment-743919613
+          path: ~/.npm
+          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-build-${{ env.cache-name }}-
+            ${{ runner.os }}-build-
+            ${{ runner.os }}-
+
+      - name: npm ci
+        run: npm ci
+
+      - name: npm run build
+        run: npm run build
+        env:
+          NODE_ENV: production
+
+      - name: Cypress tests
+        run: npm run test:ci
         env:
-          CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
-          # As recommended by the doc
-          # - https://github.com/cypress-io/github-action#record-test-results-on-cypress-dashboard
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          NODE_ENV: production
+
+      - name: Upload Cypress failure results
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: Cypress Results
+          path: |
+            .cypress/screenshots
+            .cypress/videos
+          if-no-files-found: error

.gitignore

@@ -1,9 +1,6 @@
 # IntelliJ project files
 /.idea
 
-# scss files - these should be compiled to css before commmit
-*.scss
-
 # dependencies
 /node_modules
 /.pnp

.stylelintrc.yml

@@ -4,10 +4,7 @@ plugins:
 extends:
   - stylelint-config-standard
 
-ignoreFiles:
-  # Automatically compiled from scss file
-  - ./src/bootstrap.css
-
 rules:
+  # Override @ rules
   at-rule-no-unknown: null
   scss/at-rule-no-unknown: true

README.md

@@ -23,19 +23,18 @@
 
 Main | Dev
 :---: | :---:
-[![front-grade-badge-main]][front-cq-link-main] | [![front-coverage-badge-main]][front-cq-link-main]
-[![front-grade-badge-dev]][front-cq-link-dev] | [![front-coverage-badge-dev]][front-cq-link-dev]
-[![front-cypress-badge-main]][front-cypress-link] | [![front-cypress-badge-dev]][front-cypress-link]
+[![front-grade-badge-main]][front-cq-link-main] | [![front-grade-badge-dev]][front-cq-link-dev]
+[![front-coverage-badge-main]][front-cq-link-main] | [![front-coverage-badge-dev]][front-cq-link-dev]
 
 Frontend of [Dragalia Lost info website by OM][front-site].
 
 ## Environment Variables
 
 Name | Required/Optional | Description
 :---: | :---: | :---:
-NEXT_PUBLIC_API_ROOT | Required | Root URL of the backend. This should **not** end with a slash (`/`).
-NEXT_PUBLIC_RESOURCE_ROOT | Required | Root URL of the exported resources. This should **not** end with a slash (`/`).
-NEXT_PUBLIC_DEPOT_ROOT | Required | Root URL of the data depot. This should **not** end with a slash (`/`).
+`NEXT_PUBLIC_API_ROOT` | Required | Root URL of the backend. This should **not** end with a slash (`/`).
+`NEXT_PUBLIC_RESOURCE_ROOT` | Required | Root URL of the exported resources. This should **not** end with a slash (`/`).
+`NEXT_PUBLIC_DEPOT_ROOT` | Required | Root URL of the data depot. This should **not** end with a slash (`/`).
 
 For the [current deployed website][front-site], `NEXT_PUBLIC_API_ROOT` is `https://dl-back.raenonx.cc`.