395 implement new deterministic metrics kge #396
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the metrics framework for KGE, KGEmod1, and KGEmod2 to allow for user defined constants. This PR also explores the impact of wrapper functions on query performance. By creating a wrapper around the KGE functions that ingests the KGE base models, we can specify user defined constants like below:
Alternatively, the existing method to query metrics still works despite the presence of a wrapper, shown below:
Unexpectedly, the presence of a wrapper that does not alter values within a given function results in somewhat significant performance improvements while the presence of a wrapper that does alter values within a given function results in performance similar to that of our existing metrics implementation.
I propose we implement this functionality on all existing metrics functions to standardize metrics behavior while simultaneously improving metric query performance.