Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add cmake&ninja to speed up github action build #9998

Closed
wants to merge 18 commits into from

Conversation

kaidegit
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

提交个pr等action实在是太慢了,看看ninja能否提提速

你的解决方案是什么 (what is your solution)

部分bsp使用scons+cmake+ninja编译代替scons编译

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added action github action yml imporve tools labels Feb 17, 2025
@kaidegit kaidegit marked this pull request as draft February 17, 2025 11:23
@kaidegit kaidegit force-pushed the ci-cmake branch 2 times, most recently from 3c038d8 to df29d93 Compare February 17, 2025 11:51
@kaidegit
Copy link
Contributor Author

scons
image
cmake+ninja
image
有提升但不多,感觉时间还可能还有sdk删了又拉造成的?

@kaidegit
Copy link
Contributor Author

另外几个rtduino炸flash了,可能哪里有问题

@supperthomas
Copy link
Member

可以试试.cache 方案#5969

@kaidegit
Copy link
Contributor Author

感觉主要还是bsp瘦身,sdk下到packages里后面又删了的原因。可以考虑pkgs支持全局包?或者下完拷贝?

@kaidegit
Copy link
Contributor Author

kaidegit commented Feb 18, 2025

btw,问下scons的严格模式添加了点什么啊 @supperthomas

@supperthomas
Copy link
Member

pkgs支持全局包?或者下完拷贝?

加了--strict命令scons --strict

@kaidegit
Copy link
Contributor Author

加了--strict命令scons --strict

我知道是这样,对应到编译选项是什么啊

@supperthomas
Copy link
Member

加了--strict命令scons --strict

我知道是这样,对应到编译选项是什么啊

-Werror

@supperthomas
Copy link
Member

ESP32C3看看是不是用ninja更快一些

@supperthomas
Copy link
Member

感觉主要还是bsp瘦身,sdk下到packages里后面又删了的原因。可以考虑pkgs支持全局包?或者下完拷贝?

第二次编译也要sdk也会删吗?可以不删吗

@kaidegit
Copy link
Contributor Author

第二次编译也要sdk也会删吗?可以不删吗

放在packages里的应该都被删了吧。。

还有一方面,不同bsp如果用同个sdk,优化一下也可以避免重复下载

@kaidegit
Copy link
Contributor Author

另外几个rtduino炸flash了,可能哪里有问题

#10018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action github action yml imporve tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants