Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsp/k230] 修复Kconfig中由RTT_DIR路径错误引起的无法编译问题 #10033

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

directorhorse
Copy link
Contributor

@directorhorse directorhorse commented Feb 25, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

k230的bsp,Kconfig的RTT_DIR路径配置错误导致没有RT_USING_SERIAL_BYPASS宏,从而缺少serial_bypass.h这个头文件,scons无法构建

你的解决方案是什么 (what is your solution)

将RTT_DIR由/../../rt-thread修改为/../../

请提供验证的bsp和config (provide the config and bsp)

  • BSP:bsp/k230
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commented Feb 25, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the BSP label Feb 25, 2025
@supperthomas
Copy link
Member


这里加下ci检查

@github-actions github-actions bot added the action github action yml imporve label Feb 25, 2025
@supperthomas
Copy link
Member

image

@supperthomas supperthomas changed the title 修复Kconfig中由RTT_DIR路径错误引起的无法编译问题 [bsp/k230] 修复Kconfig中由RTT_DIR路径错误引起的无法编译问题 Feb 25, 2025
@supperthomas
Copy link
Member

这个不好加就暂时先不加了吧。如果需要加,可以感兴趣可以参考
https://github.com/RT-Thread/rt-thread/pull/9901/files

@supperthomas supperthomas merged commit 2fffae7 into RT-Thread:master Feb 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action github action yml imporve BSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants