Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsp][wch] move ch32v20x sdk to package #10023

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

kaidegit
Copy link
Contributor

@kaidegit kaidegit commented Feb 22, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

bsp瘦身

你的解决方案是什么 (what is your solution)

移动到package

请提供验证的bsp和config (provide the config and bsp)

  • BSP:

ch32v208w-r0

  • .config:

  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added BSP action github action yml imporve BSP: WCH BSP related with WCH labels Feb 22, 2025
@supperthomas
Copy link
Member

readme完善一下加一下pkgs --update,其他几个也加一下

@kaidegit kaidegit marked this pull request as ready for review February 25, 2025 10:16
@supperthomas
Copy link
Member

supperthomas commented Feb 25, 2025

bsp/wch/risc-v/ch32v307v-r1/README_zh.md
bsp/wch/risc-v/ch32v208w-r0/readme.md
wch/risc-v/yd-ch32v307vct6
之前改的几个也帮忙加一下

@kaidegit
Copy link
Contributor Author

那些另起pr加吧。。和这个pr没啥关系吧。。

@kaidegit
Copy link
Contributor Author

kaidegit commented Feb 25, 2025

之前写的readme啥啊乱糟糟的图也用绝对路径的也给合进去的,维护人也不写的

@supperthomas
Copy link
Member

之前写的readme啥啊乱糟糟的图也用绝对路径的也给合进去的,维护人也不写的

先加个pkgs --update 提示一下吧

@kaidegit
Copy link
Contributor Author

起手一个rtt studio的我也不知道怎么加提示

@supperthomas supperthomas merged commit 78f95ab into RT-Thread:master Feb 25, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action github action yml imporve BSP: WCH BSP related with WCH BSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants