Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redis_get/redis_set from functions where possible##274 #280

Closed
wants to merge 4 commits into from
Closed

Remove redis_get/redis_set from functions where possible##274 #280

wants to merge 4 commits into from

Conversation

npalchur
Copy link
Contributor

reducing the multiple times calling cache to improve better optimization

adhil0
adhil0 requested changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@adhil0 adhil0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work -
Marked some issues. There are also some linting issues that can be resolved using black or ruff.

.vscode/settings.json Outdated Show resolved Hide resolved
dashboard/src/t5gweb/ui.py Show resolved Hide resolved
dashboard/src/t5gweb/t5gweb.py Outdated Show resolved Hide resolved
dashboard/src/t5gweb/ui.py Outdated Show resolved Hide resolved
dashboard/src/t5gweb/ui.py Outdated Show resolved Hide resolved
@dcritch
Copy link
Contributor

dcritch commented Mar 28, 2024

lgtm. thanks Naresh!

adhil0
adhil0 requested changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@adhil0 adhil0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last change - can you change all instances of redis_get("time_stamp") to redis_get("timestamp")? That's what our cache entry is

@npalchur
Copy link
Contributor Author

duplicate

@npalchur npalchur closed this Mar 28, 2024
@adhil0 adhil0 mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhil0 adhil0 adhil0 requested changes

@dcritch dcritch dcritch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npalchur @dcritch @adhil0