css for line counter #150
Merged
css for line counter #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skvrnami
reviewed
Jan 8, 2025
inst/app/www/custom.css
Outdated
| @@ -77,6 +77,7 @@ p.docpar::before { | |||
| left: -45px; /* Negative offset to place numbers in the padding area */ | |||
| width: 30px; /* Fixed width for alignment */ | |||
| text-align: right; /* Align numbers to the right */ | |||
| font-family: 'Courier New', Courier, monospace; /* Specify a monospace font */ | |||
| color: lightgray; /* Style the numbers */ | |||
There was a problem hiding this comment.
I suggest changing the colour to darker gray (e.g. #959595), the current lightgray has low contrast (see https://coolors.co/contrast-checker/d3d3d3-ffffff). According to some accessibility guidelines, the contrast should be at least 3 (https://www.colorlabs.net/posts/what-is-the-minimum-color-contrast-ratio-for-non-text-elements-in-wcag).
There was a problem hiding this comment.
Absolutely, I intended to change it myself, having hard time reading it. It is a tradeoff though, as we want the actual text to stand out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement (user request): line counter