Permissions issue

[martin-hajek]

I was invited to join a project. At first I had only a limited number of permissions (standard for a new member).
Then I was granted all permissions. I created a new category without any problems. However, after adding a code to the category, a warning message popped up that I did not have sufficient permissions to make changes to the codes or categories created by others. Nevertheless, the action was executed on the front-end and the code was added to the category.

In the Analysis page, the newly created categories show up but do not filter segments.
After restarting the session the categories still exist but they are empty, without codes. It means that codes were not added to the categories in the database.

[hlageek]

Sounds like this issue would only occur if the project owner changes permissions while project member is in active seesion without reload If you repeat the same action now, the codes-categories behave as expected?

[martin-hajek]

The issue still persists even after reload.
I cannot exclude the possiblity that we were both in active session when the permissions were changed, but yes, it shouldn't persist indefinitely.

[hlageek]

Potentially tracked to observer for input$edges_category in mod_categories.R, where we first check for narrow condition (codebook_modify == 1) before checking for broader condition codebook_other_modify == 1. The order should be reversed - first check broader condition and execute if satisfied, else check narrow condition and execute, else abort if neither of the permissions is sufficient. #TODO

Edit:
This is not necessarily the correct way to go about it. If narrow condition is satisfied, there is no need for checking the broader one. But in case, the logic has to be fixed to work as expected.

[hlageek]

If @martin-hajek can check the bugfix with
devtools::install_github("RE-QDA/requal@codebook_permissions_fix")
then please report success in #156.

[martin-hajek]

Tested and works fine.