Type Constraint initializers #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This first mostly-mechanically implemented pass didn't type `__init__` for these classes, because of extra signature review becoming entailed: * `ClosedConstraintComponent` * `InConstraintComponent` * `StringBasedConstraintBase` Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Note: A revision away from an inlined iterator is due to a difference between pySHACL's RDFNode and RDFLib's Node. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Note: A revision away from `IdentifiedNode` is due to `URIRef` and `BNode` providing `.n3()`, while the parent class `IdentifiedNode` does not. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Note: Extra type assertions are entered because broader type in `StringBasedConstraintBase` can't be narrowed in child classes. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
|
This PR is ready for review. |
ashleysommer
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect there will be some discussion and/or revision on error handling style. Feedback and/or pushed revisions welcome.