Enable type checking in Continuous Integration #250
Conversation
Disclaimer: Participation by NIST in the creation of the documentation of mentioned software is not intended to imply a recommendation or endorsement by the National Institute of Standards and Technology, nor is it intended to imply that any specific software is necessarily the best available for the purpose. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
|
Ah, and apparently, some setting may need to be turned on in order to run GitHub Actions on this repository (possibly Settings / Actions / General / Allow [x] actions and reusable workflows). IIRC, closing the PR and re-opening it will trigger an Action run. |
The option "Allow all actions and reusable workflows" is already enabled. |
|
Is there a checkbox, or "Run first Action" interface, at the bottom of this PR in the view of any project Administrators? If not: I have a hunch that the CI not firing is an anti-abuse mechanism. I'm not a project maintainer, so I probably can't initiate the Actions infrastructure. I think if a project maintainer adds an Actions YAML workflow file first, CI would start firing on this. I'd thought project Contributors could get by this, but it seems no, & in the bigger picture that's fine by me. Maybe just the first 36 lines of the YAML in this PR should be merged first? I'll file another PR. |
This patch is an attempt to enable GitHub Actions. It is a reduced implementation of the patch in PR 250, and intentionally doesn't run tests. References: * RDFLib#250 Disclaimer: Participation by NIST in the creation of the documentation of mentioned software is not intended to imply a recommendation or endorsement by the National Institute of Standards and Technology, nor is it intended to imply that any specific software is necessarily the best available for the purpose. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
|
After merging #252, the tests on here are now running! |
|
Passed type checking! |
This Pull Request adds type checking to a continuous integration (CI) process outside of the two CI systems currently encoded in this repository. The CI workflow set up uses GitHub Actions, but in a matter naïve to other systems that have some scripting written in this repository. E.g., I'm not familiar with
tox.Feedback or revisions are welcome on this PR. My objective with the PR is to type-check code on the way in. I'm aware that there are other tests, but I'm not sure how they're all meant to be called, so the PR starts small: Check types on the oldest and newest Python releases designated in
pyproject.toml.Disclaimer:
Participation by NIST in the creation of the documentation of mentioned software is not intended to imply a recommendation or endorsement by the National Institute of Standards and Technology, nor is it intended to imply that any specific software is necessarily the best available for the purpose.