-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dev on master #1110
Closed
Closed
Merge dev on master #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CMakeLists.txt Update CMakeLists.txt again Update CMakeLists.txt again Update CMakeLists.txt again Update CMakeLists.txt again Update CMakeLists.txt again Update CMakeLists.txt again Update CMakeLists.txt again Update CMakeLists.txt again Update CMakeLists.txt again Update CMakeLists.txt again
Added califa/geobase folder Use of dynamic_cast
Added automatic generation for CALIFA root geometry Minor changes for R3BAlpide.cxx
Changed the names for CALIFA root geometries
Update input/p2p/qfs.C Added Licence headers Minor change in main.yml Minor change in main.yml Minor change in main.yml Minor change in main.yml Minor change in main.yml More modifications for CI tests
Changed containers by .githubfiles Added && build-r3broot to main.yml Added && build-r3broot to main.yml Added && build-r3broot to main.yml Removed && build-r3broot from main.yml Clang-format applied over all files
Minor change in .github/workflows/main.yml
Commented glad-tpc CI test again
Added missing includes, FairRootManager and TCA Updated Neuland lambda expression CI changes: * CMake errors will now be sent to console * clang-format will upload a ready-to-apply diff to sprunge.us on failure. Rebased. Moved all format related scripts to util.
Removed stack->SetDebug in gconfig/g4Config.C
Clang-format Solved problems with field/R3BFieldPar.cxx Update again license years
Use of R3BStack instead of FairStack in gconfig/g3Config.C Added again FATAL_ERROR to detect failed tests Test error deliberate Inverting error
testCalifaSimulation.C: Update name for the Califa root geometry Update r3bgen/test/testR3BPhaseSpaceGeneratorIntegration.C
Update version v3 to v4 Removed unused includes
Clean-up and minor improvements in los classes. Include timing of S2 hit after subtraction of the reference time in FrsSciPosCalData. Bug fix in R3BFrsSciTcal2Cal when obtaining good pairs of hits of left and right PMTs. Update IncomingData to reconstruct S2(FrsSci) to LosCal for s091 experiment. Los CFD out was used for the Tref signal for S2, so LosCal is used for reconstructing ToF specific to the experiment. When multiple hits in Los are seen, only selecting good hit wrt the trigger timing is choosen.
Clang-format
CMake targets imported from ROOT using config mode is suggested both from ROOT and FairRoot. Libraries generated with different detectors are also represented by proper CMake targets for easier dependency management.
Fix the value of the total energy
Conan package manager is now added to R3BRoot. By default, it's disable. Building the project with conan package manager can be achieved with cmake preset and conan cmake wrapper as a git submodule.
Adding new class R3BDataMonitor for easy histogram operations in FairTask. New class ValueError can be used to represent values with errors. R3BFileSource2 now can handle root files just with root tree inside. Documentation of these new classes and changes have been added to the README.md in the r3bbase folder.
Add a new feature of FileSource2 that can specify each individual input file with or without tree option.
This reverts commit e34265b.
Update list of Authors Added zenodo DOI Minor Added zenodo DOI gROOT->Reset() for create_califa_geo.C Changed CMakeLists.txt Changed CMakeLists.txt Another tests Again nov22p1 Recover CMakeLists.txt for califa/geobase Update github workflow
Minor change Added new zenodo ID Update COPYRIGHT Added more authors Added more coauthors
Update Connecting again the califa geometry test
… run the CI tests
Added bestpractices badge Update readme Update readme Update readme Update readme Update Copyright Added Deniz to the list of contributors Added fair-software.yml Update zenodo file Minor Minor Update github workflows Update github workflows Update scripts for generating json files Added more contributors Update codemeta.json Update codemeta.json Update codemeta.json Minor change readme Minor change Clang-format Update authors Minor change for zenodo Update cleanup_cache.yml Deleted old folders xball, mfi and lumon Added a display for cmake status Added a display for SUPPORTED_CXX_STANDARDS Added a display for CMAKE_CXX_STANDARD Removed old detector classes for lumon, mfi and xball Removed xball from compilehelper/CMakeLists.txt Added color to supported C++ standards Minor change in the general CMakeLists-txt
Added minor versions for fairsoft and fairroot
Further changes: - Remove conda usage in CI - Add GTest from CMakeFetchContent
…e by Luke Rose Minor change Minor change
Changed imagen for debian10 Changed imagen for debian10 again Changed imagen for debian10 again Changed imagen for debian10 again Changed imagen for debian10 again Again Again Update of libc6 Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
dev
branch