Handle failure of the unfaded EXP model in calc_Huntley2006() #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the fit of the unfaded EXP model fails, what we do depends on fit.method: - for fit.method = "EXP" this is irrecoverable, so stop with an error - for fit.method = "GOK", as this model was only attempted to find a starting point, we can try again, this time using the simulated fit to set the starting point
|
I'm merging as this is strictly better than the current state: in the non-failure case, all is equal to before, but in the failure case we report an error (instead of an uncontained crash) for EXP, and we try again for GOK, potentially fitting more models than before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #549.