Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the replace_metadata<-() method for the RLum.Analysis class #525

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

mcol
Copy link
Contributor

@mcol mcol commented Dec 9, 2024

After a lot of struggling, this seems to be working (at least for the basic tests). Part of #480.

mcol added 2 commits December 9, 2024 18:02
This is particularly important for RLum.Analysis objects, as otherwise we
may get a lot of messages when a subsetting expression produced an empty
selection, which in that context are not really helpful.
Copy link
Member

@RLumSK RLumSK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible and working to me! Thanks!

@RLumSK RLumSK merged commit 6428b48 into master Dec 9, 2024
9 checks passed
@mcol mcol deleted the issue_480_p3 branch December 9, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants