html_helper #16
Draft
html_helper #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanclarke
reviewed
Sep 9, 2021
README.md
Outdated
| This repo contains these sets | ||
|
|
||
| - @qubit/utils/dom | ||
| - @qubit/html |
There was a problem hiding this comment.
should this be @qubit/utils/html?
alanclarke
reviewed
Sep 9, 2021
| @@ -154,3 +161,28 @@ Functionality is the same as described in https://developer.mozilla.org/en-US/do | |||
| ```js | |||
| const closestElement = closest(targetElement, selectors) | |||
| ``` | |||
|
|
|||
| ### @qubit/html | |||
There was a problem hiding this comment.
@qubit/html would be a different package right?
There was a problem hiding this comment.
I was wondering if it should be part of utils because it is directly related to html element creation
There was a problem hiding this comment.
Right but the name @qubit/html implies a separate package, did you mean @qubit/utils/html?
|
Just wondering what kind of stuff do we want to live here vs stuff that should live in the |
|
also, do we want to encourage people to create elements this way vs using jsx? |
BenKandelaars
force-pushed
the
html_helper
branch
6 times, most recently
from
6e1d88c to
1f08a37
Compare
BenKandelaars
force-pushed
the
html_helper
branch
from
81973d7 to
a858416
Compare
|
I've found this useful when doing badging placements that are so small preact feels like overkill |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a few small badge type placements. Found it clearer to use a configuration based API to create elements