Decouple run and development dependencies. #102
Conversation
kklein
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
=======================================
Coverage 94.74% 94.74%
=======================================
Files 15 15
Lines 1807 1807
=======================================
Hits 1712 1712
Misses 95 95 ☔ View full report in Codecov by Sentry. |
| coverage = "pytest tests --cov=metalearners --cov-report=xml --cov-report term-missing --color=yes" | ||
| # Note that this task will fail on systems without bash. | ||
| nb-convert = "nb-convert.sh" | ||
| nb-mypy = "mypy docs/examples/*.py" | ||
|
|
||
| [dependencies] |
There was a problem hiding this comment.
The depedencies section is now equal to the conda-forge recipe's run requirements except for:
- An extra upper bound on scikit
- The absence of
typing-extensions
My hunch would be that typing-extensions doesn't actually belong in the recipe's run requirements but I'm not sure.
|
Hi @pavelzw ! Would you mind taking a look at this? |
pixi.toml
Outdated
| setuptools-scm = "*" | ||
| setuptools = ">=61" |
There was a problem hiding this comment.
these two (and also pip) should go into [host-dependencies] as they are also required for the regular postinstall task and thus need to be in the default envs as well.
pixi.toml
Outdated
|
|
||
| [feature.lint.dependencies] | ||
| pip = "*" |
There was a problem hiding this comment.
I don't think so; good catch!
Checklist
CHANGELOG.rstentry