Skip to content

Commit

Permalink
fix: scrollcontroller not same on merged subscriptions page
Browse files Browse the repository at this point in the history
  • Loading branch information
HarlJo committed Apr 7, 2024
1 parent ec15de4 commit 9b2fdf7
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
13 changes: 10 additions & 3 deletions lib/subscriptions/_list.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import 'package:provider/provider.dart';
import 'package:quacker/generated/l10n.dart';

class SubscriptionUsers extends StatefulWidget {
const SubscriptionUsers({Key? key}) : super(key: key);
final ScrollController scrollController;
const SubscriptionUsers({super.key, required this.scrollController});

@override
State<SubscriptionUsers> createState() => _SubscriptionUsersState();
Expand Down Expand Up @@ -61,21 +62,27 @@ class _SubscriptionUsersState extends State<SubscriptionUsers> {
]));
}

return SubscriptionUsersList(subscriptions: state);
return SubscriptionUsersList(
subscriptions: state,
scrollController: widget.scrollController,
);
},
);
}
}

class SubscriptionUsersList extends StatelessWidget {
final ScrollController scrollController;
final List<Subscription> subscriptions;

const SubscriptionUsersList({Key? key, required this.subscriptions}) : super(key: key);
const SubscriptionUsersList({Key? key, required this.subscriptions, required this.scrollController})
: super(key: key);

@override
Widget build(BuildContext context) {
return ListView.builder(
shrinkWrap: true,
controller: scrollController,
padding: const EdgeInsets.symmetric(vertical: 8),
itemCount: subscriptions.length,
itemBuilder: (context, i) {
Expand Down
4 changes: 3 additions & 1 deletion lib/subscriptions/subscriptions.dart
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ class SubscriptionsScreen extends StatelessWidget {
SubscriptionGroups(
scrollController: scrollController,
),
SubscriptionUsers()
SubscriptionUsers(
scrollController: scrollController,
)
],
),
);
Expand Down

0 comments on commit 9b2fdf7

Please sign in to comment.