-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gate modifiers #70
Conversation
Reorganize docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice work!
I link the new structure, however I was struggling a bit with the fact that unitary instructions are much better known in the literature as 'gates'. So I was trying to make it a bit more clear to the reader where they could find more info on gates from the General Overview page. See if you like the suggestions, or if we can think of it some other way.
I've also adjusted/reorganized a bit the text on the gate modifiers.
docs/language_specification/statements/instructions/unitary_instructions.md
Outdated
Show resolved
Hide resolved
docs/language_specification/statements/instructions/unitary_instructions.md
Outdated
Show resolved
Hide resolved
Rename unitary instruction 'Gates' section to 'Named gates'. Update links to 'Gates' section to point to 'Named gates'. Fix link to 'Grammar sections' section.
Thanks @elenbaasc!
I think I've applied most of your comments, plus:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for the adjustments!
I have added some minor tweaks.
Incidentally, could you add the reset
as a keyword to the table of Keywords, with its use 'Measure instruction'. This is described in ticket CQT-248, but it's such a small change that we could just do it here already.
docs/language_specification/statements/instructions/unitary_instructions.md
Outdated
Show resolved
Hide resolved
docs/language_specification/statements/instructions/unitary_instructions.md
Outdated
Show resolved
Hide resolved
docs/language_specification/statements/instructions/unitary_instructions.md
Outdated
Show resolved
Hide resolved
docs/language_specification/statements/instructions/unitary_instructions.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Elenbaas <67630508+elenbaasc@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor editing of the intro to named gates.
Good job adding the modifiers to the keywords!
Add gate modifiers section to docs.
Reorganize docs.