Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gate modifiers #70

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Add gate modifiers #70

merged 6 commits into from
Oct 22, 2024

Conversation

rturrado
Copy link
Contributor

Add gate modifiers section to docs.
Reorganize docs.

@rturrado rturrado requested a review from elenbaasc October 17, 2024 08:40
Copy link
Collaborator

@elenbaasc elenbaasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice work!

I link the new structure, however I was struggling a bit with the fact that unitary instructions are much better known in the literature as 'gates'. So I was trying to make it a bit more clear to the reader where they could find more info on gates from the General Overview page. See if you like the suggestions, or if we can think of it some other way.

I've also adjusted/reorganized a bit the text on the gate modifiers.

mkdocs-base.yml Outdated Show resolved Hide resolved
docs/language_specification/general_overview.md Outdated Show resolved Hide resolved
docs/language_specification/general_overview.md Outdated Show resolved Hide resolved
Rename unitary instruction 'Gates' section to 'Named gates'.
Update links to 'Gates' section to point to 'Named gates'.
Fix link to 'Grammar sections' section.
@rturrado
Copy link
Contributor Author

Thanks for the nice work!

Thanks @elenbaasc!

I link the new structure, however I was struggling a bit with the fact that unitary instructions are much better known in the literature as 'gates'. So I was trying to make it a bit more clear to the reader where they could find more info on gates from the General Overview page. See if you like the suggestions, or if we can think of it some other way.

I've also adjusted/reorganized a bit the text on the gate modifiers.

I think I've applied most of your comments, plus:

  • Rename unitary instruction 'Gates' section to 'Named gates'.
  • Update links to 'Gates' section to point to 'Named gates'.
  • Fix link to 'Grammar sections' section.

Copy link
Collaborator

@elenbaasc elenbaasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the adjustments!

I have added some minor tweaks.

Incidentally, could you add the reset as a keyword to the table of Keywords, with its use 'Measure instruction'. This is described in ticket CQT-248, but it's such a small change that we could just do it here already.

rturrado and others added 3 commits October 21, 2024 16:47
Copy link
Collaborator

@elenbaasc elenbaasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor editing of the intro to named gates.

Good job adding the modifiers to the keywords!

mkdocs-base.yml Show resolved Hide resolved
@elenbaasc elenbaasc self-requested a review October 22, 2024 08:13
@elenbaasc elenbaasc merged commit 0a03d6b into master Oct 22, 2024
1 check passed
@elenbaasc elenbaasc deleted the CQT-238-Add-gate-modifiers branch October 22, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants