Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CQT-84] Add reset instruction #54

Merged
merged 20 commits into from
Aug 16, 2024

Conversation

rturrado
Copy link
Contributor

@rturrado rturrado commented Aug 1, 2024

Add an entry in the Statements section.

@rturrado rturrado requested a review from elenbaasc August 1, 2024 12:31
@rturrado rturrado changed the title Add reset instruction [CQT-84] Add reset instruction Aug 2, 2024
@rturrado rturrado closed this Aug 7, 2024
@rturrado rturrado reopened this Aug 7, 2024
@rturrado rturrado requested a review from juanboschero August 7, 2024 15:55
Copy link
Collaborator

@elenbaasc elenbaasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the page! I have added a few suggestions to the text.

@rturrado rturrado requested a review from elenbaasc August 10, 2024 12:28
@elenbaasc
Copy link
Collaborator

Incidentally, I noticed a small error in docs/language_specification/types.md:
Line 8: qubit[size] should be bit[size] .

rturrado and others added 5 commits August 13, 2024 13:05
@rturrado rturrado requested a review from elenbaasc August 13, 2024 11:45
rturrado and others added 2 commits August 13, 2024 15:03
Co-authored-by: Chris Elenbaas <67630508+elenbaasc@users.noreply.github.com>
Co-authored-by: Chris Elenbaas <67630508+elenbaasc@users.noreply.github.com>
@rturrado rturrado requested a review from elenbaasc August 13, 2024 13:28
Copy link
Contributor Author

@rturrado rturrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I like it.

I have fixed a few typos.

I don't like the italics for the titles of the How to read sections, but I understand we want to show a difference between contents and how to read those contents.

elenbaasc and others added 3 commits August 15, 2024 18:05
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
elenbaasc and others added 4 commits August 15, 2024 18:06
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
@elenbaasc
Copy link
Collaborator

elenbaasc commented Aug 15, 2024

Great work, I like it.

I have fixed a few typos.

I don't like the italics for the titles of the How to read sections, but I understand we want to show a difference between contents and how to read those contents.

I'm not a fan of the italics either, but indeed I want to make a distinction and mkdocs doesn't offer much better formatting options.

Thanks for the feedback! I approve the changes :)

@elenbaasc elenbaasc merged commit a1427ee into master Aug 16, 2024
1 check passed
@elenbaasc elenbaasc deleted the CQT-84-add-reset-instruction-to-c-qasm-spec branch August 16, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants