Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear why test status is listed as failure #293

Closed
garrison opened this issue Dec 8, 2022 · 3 comments
Closed

Unclear why test status is listed as failure #293

garrison opened this issue Dec 8, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@garrison
Copy link
Member

garrison commented Dec 8, 2022

Steps to reproduce the problem

Look at https://qiskit.org/ecosystem/.

What is the current behavior?

There are a number of jobs that the page suggests are failing, but when one clicks on the associated Action, it appears to have passed. For instance, three of the jobs under Quantum Random Access Optimization are red, but after clicking "see test logs", it lists the status as Success. I've noticed this happens for some other packages too, e.g. pytorch-quantum.

What is the expected behavior?

Either status should be green, or it should be obvious why a job failed.

@garrison garrison added the bug Something isn't working label Dec 8, 2022
@mickahell
Copy link
Collaborator

mickahell commented May 3, 2023

Hi @garrison I have a part of the answer :)
When we created the Actions, we wanted the jobs to always succeed to finished in order and then generating a report to push in the issue concerned indicating if the tests passed or failed.

Example : #355

@mickahell mickahell added enhancement New feature or request and removed bug Something isn't working labels Jul 3, 2023
@mickahell
Copy link
Collaborator

Transform your issue as feature, in order to check how to improve the Actions output

@mickahell mickahell added documentation Improvements or additions to documentation and removed enhancement New feature or request labels Jul 31, 2023
@mickahell
Copy link
Collaborator

Cover by #487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants