Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pietro integrates some best practices within Cobra #154

Open
sandervh14 opened this issue Mar 10, 2023 · 0 comments · May be fixed by #166
Open

Pietro integrates some best practices within Cobra #154

sandervh14 opened this issue Mar 10, 2023 · 0 comments · May be fixed by #166
Assignees
@pietrodantuono
Labels
data engineering enhancement New feature or request good first issue Good for newcomers
Milestone
v1.1.2

Comments

@sandervh14
Copy link
Contributor

Task Title

Task: Pietro integrates some best practices within Cobra

Task Description

Pietro proposed the following:

  • commit message style
  • good practices (change log, etc)
  • invoke: avoiding to run commands yourself before push & automatic CI/CD does it (black linter, pytests, document creation, etc)

The black linter is used already, but not fully done yet: #54
I'd say, check out the current commit message style, current CI/CD and unit tests development way of working and indeed make your proposals below... We'll be happy to welcome improvements. 👍
@sandervh14 sandervh14 added enhancement New feature or request good first issue Good for newcomers data engineering labels Mar 10, 2023
@sandervh14 sandervh14 added this to the 2023-03 milestone Mar 10, 2023
@sandervh14 sandervh14 modified the milestones: 2023-03, 2023-04 Apr 7, 2023
pietrodantuono added a commit that referenced this issue Apr 12, 2023
@pietrodantuono
new: dev: Invoke: test task implemented #154
aaedd43 
The invoke package has been added to the dev requirements. The "inv" command has been configured, and the test task has been implemented. Call inv test and take a look.
pietrodantuono added a commit that referenced this issue Apr 12, 2023
@pietrodantuono
fix: dev: Fixed inv test command on Windows machines #154.
7aecf53
pietrodantuono added a commit that referenced this issue Apr 12, 2023
@pietrodantuono
chg: dev: Minor changes #154
1111b2a
pietrodantuono added a commit that referenced this issue Apr 12, 2023
@pietrodantuono
fix: dev: Minor fix #154
ef891b3
pietrodantuono added a commit that referenced this issue Apr 12, 2023
@pietrodantuono
new: dev: Invoke: quality task implemented #154
d1cfaeb 
Run `inv qa` to test this functionality. CAVEAT: at the moment, qa runs flake8, pylint and mypy sequentially. Black is not run because it would modify the source code.
pietrodantuono added a commit that referenced this issue Apr 18, 2023
@pietrodantuono
new: dev: Invoke: nb task implemented for UNIX-like systems #154
853ef25 
Run `inv nb` to test this functionality. CAVEAT: at the moment, nb runs on Linux and macOS, while still gives an error on Windows 11. It will be fixed soon.
pietrodantuono added a commit that referenced this issue Apr 21, 2023
@pietrodantuono
new: dev: #154 Invoke: nb task implemented for Windows systems
ecb014c
pietrodantuono added a commit that referenced this issue Apr 21, 2023
@pietrodantuono
fix: dev: #154 Invoke: fixed nb task for Windows systems
50ba7e2
pietrodantuono added a commit that referenced this issue Apr 21, 2023
@pietrodantuono
new: dev: #154 git-changelog dependency for better automated change l…
bd9c06e 
…ogs.
@pietrodantuono pietrodantuono linked a pull request Apr 21, 2023 that will close this issue
Open
@sandervh14 sandervh14 modified the milestones: 2023-04, 2023-05 May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pietrodantuono pietrodantuono

Labels
data engineering enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v1.1.2
Development

Successfully merging a pull request may close this issue.

154 pietro integrates some best practices within cobra PythonPredictions/cobra
2 participants
@sandervh14 @pietrodantuono