ProductInfoHeader UI 구현 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
해당 파일은 제품 상세 페이지 최상단에 있는 HeaderView입니다.
현재 제외되는 항목 – 제품의 카테고리 레이블 – 제품의 원래 가격 레이블
Closed
isGeekCode
previously approved these changes
Jan 27, 2024
WhiteHyun
reviewed
Jan 27, 2024
PyeonHaeng-iOS/Sources/Scenes/ProductInfoScene/ProductInfoView.swift
Outdated
Show resolved
Hide resolved
- Renamed an existing color to `main` and updated its hue to green. - Added a new color named `blur` for additional UI elements.
- Created an extension of `Color` to expose ColorResource to external modules.
- Created an extension of `Image` to expose ImageResource to external modules
…11' into feature/ProductInfo/6 # Conflicts: # PyeonHaeng-iOS.xcodeproj/project.pbxproj
|
@PyeonHaeng/ios 요청 사항 수정 및 Conflict 수정하여 다시 요청보냅니다! |
WhiteHyun
reviewed
Jan 28, 2024
PyeonHaeng-iOS/Sources/Scenes/ProductInfoScene/ProductInfoHeader.swift
Outdated
Show resolved
Hide resolved
Merged
WhiteHyun
reviewed
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots 📸
고민, 과정, 근거 💬
거의 대부분의 것들이 생소한 것들이라.. 첫 PR은 대략적으로 UI구성만 했습니다.
Extensions같은 필요한 폴더는 일단 임의로 추가하였습니다.UI Tests에 관하여..
UITests 코드를 작성하다가 머리가 터져버렸습니다..
테스트 코드 작성하다가 다 지움사실 이번 화면은 사용자의 인터렉션이 없어서 굳이 UI Test를 작성할 필요는 없었다고 생각이 들지만,
Localizable이 제대로 사용자에게 보여지는가? 에 대해서 테스트 코드를 작성하는 도중
'너무 지엽적인 것까지 UITest를 작성하여 시간을 뺏기는 것이 아닌가?' 라는 생각이 들더라구요..
예를 들어서 화면 전환도 A화면에서 B화면으로 잘 전환되는가?처럼..혹시 이 부분에 대해서 의견이나 조언같은 것을 주실 수 있다면 감사하겠습니다. _ _
References 📋