Improve flexibility of the precision parameter in the CWT implementation. #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiyasan
changed the title
agriyakhetarpal
approved these changes
Apr 15, 2025
There was a problem hiding this comment.
Thanks, @meiyasan! Not a maintainer over here, but I think the change looks good in its current form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @rgommers ,
I had many issues in controlling the precision of the wavelet (
def wavefun()). This issue has been mentioned several times already, but never committed. I think this is a rather important fix allowing for more flexibility in playing with CWT.So please find the minimal modification necessary allowing for better precision and removing artifacts in the low-frequency region (high scale values).
Please consider if possible, this is important parameter to adjust. In the current master, the value is hardcoded in
_cwt.pytoprecision=10, this is not so good.