Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow heat-venting in all heating systems and impose small penalty for water tank chargers #1563

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

amos-schledorn
Copy link
Contributor

@amos-schledorn amos-schledorn commented Mar 3, 2025

Changes proposed in this Pull Request

This PR

  • allows heat-venting in all heating systems through system-type-specific config settings.
  • introduces marginal costs on heat-venting and water tank chargers (in the future also pit storage chargers).
  • renames the config setting config.sector.marginal_cost_storage to config.sector.marginal_cost_home_battery_storage for clarity
  • slightly improves the docs of gas boiler must run conditions

This should avoid artificial heat-venting through water tank charging/discharging at efficiencies < 1 (c.f. #1546)

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

Testing

  • Tested with test/config.perfect.yaml. Artificial heat-venting through water tank charging/discharging is fully removed.

@amos-schledorn amos-schledorn marked this pull request as draft March 3, 2025 15:45
@amos-schledorn
Copy link
Contributor Author

@fneum I've implemented this following our discussion but I'm not totally happy. Ideally, we would use the config.cost.marginal_cost setting.
Though that's only used in add_electricity but not in prepare_sector_network. What do you think?
If we stick to the current implementation, we should probably, to avoid confusion, rename config.sector.marginal_cost_storage which currently only modifies marginal costs for distribution grid batteries.

@amos-schledorn amos-schledorn changed the title feat: add marginal cost for water tank chargers Allow heat-venting in all heating systems and impose small penalty for water tank chargers Mar 3, 2025
@amos-schledorn amos-schledorn marked this pull request as ready for review March 3, 2025 17:55
@amos-schledorn amos-schledorn requested a review from fneum March 3, 2025 17:55
@amos-schledorn amos-schledorn marked this pull request as draft March 3, 2025 17:56
@amos-schledorn amos-schledorn removed the request for review from fneum March 3, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant