-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(solve): Fix planning_horizons in solve_network #1560
Conversation
In perfect foresight, the planning_horizons param remains the list of all planning horizons (to trigger re-runs). The current planning horizons is always taken from the planning_horizons wildcard and passed into extra_functionality as a partial kwarg.
In this PR, if CCL is added to the perfect forecast, errors will occur as shown in the following image: This is because the network is missing
Run the command: I think it doesn't affect the merging of this PR; this is just a reminder that there are still issues when adding CCL to the perfect forecast. |
@yechenyan you are right, i added now a very concrete error message, that CCL has not been implemented for perfect foresight, yet |
the |
Follow-up to #1537 .
Closes #1551 .
Changes proposed in this Pull Request
In perfect foresight, the planning_horizons param remains the list
of all planning horizons (to trigger re-runs).
The current planning horizons is always taken from the planning_horizons
wildcard and passed into extra_functionality as a partial kwarg.
Checklist