using config_provider exlusively in additional_functionality #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
rules/solve_myopic.smk
Outdated
| limits_capacity_max=config_provider("limits_capacity_max"), | ||
| limits_volume_min=config_provider("limits_volume_min"), | ||
| limits_volume_max=config_provider("limits_volume_max"), | ||
| co2_budget_national=config_provider("co2_budget_national"), |
There was a problem hiding this comment.
@toniseibold just a comment: as these keys are specifications coming from the ariadne workflow (which stand-alone pypsa-eur does not use), perhaps we can rather take a modular approach and collect these entries under solving -> constraints in the ariadne repo, rather than explicitly making pypsa-eur aware of them?
|
Added configs for boundary conditions in solving as proposed by @FabianHofmann |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for PyPSA/pypsa-ariadne#154
Changes proposed in this Pull Request
Adding parameters in the rule with
config_providerto ensure handing over scenario specific configs properly.Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.