-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source distribution missing workspace files #1893
Comments
Have you tried rebuild a new sdist using newer version of maturin? You might have been using a pretty old version of maturin to publish which produced a broken one. |
This pinned version is something we should look into, however I run a recent version (1.4.0) locally and use that to generate an sdist. I get the same result when installing it as I do from PyPy. |
Thanks, I'll take a look later. |
Hey, just want to follow up on what the best path forward is here. I'm happy to help resolve this if needed, though I don't have any current knowledge of the codebase. |
It's a bit complicated, I haven't have the time to think about a good solution yet. I recently had a surgery, still resting. |
Sorry to hear that, hope you feel better. |
Hey @messense , is there any progress or recommended direction for this issue? |
Bug Description
Hello, we're running into an issue, specifically on FreeBSD with installing the source distribution of chia_rs on platforms where a binary wheel has not been pre-built.
The wheel can be found at this link in the workspace. The wheel crate is part of the parent workspace and depends on other members in the repo. When running
maturin sdist -m wheel/Cargo.toml
, this generates a source distribution that is missing the binaryfuzz
crates (fuzz tests written with libfuzzer). Although these are not dependencies of the wheel (which is presumably why they aren't included), they are listed as members in the parent workspace'sCargo.toml
file.As such, when running
pip install
on the source distribution, it fails when trying to gather the workspace metadata with Cargo (which is done when runningpip install chia_rs
on FreeBSD, or reproduced withpip install --no-binary chia_rs chia_rs
). The source distribution in question can be found from the chia_rs files on PyPi.In my eyes there are a couple methods of resolving this issue:
fuzz
in this case, to prevent errors like this from occurring.However, my knowledge of Maturin is limited, so if there are other ways to resolve this, workarounds, or if the
chia_rs
wheel is misconfigured, I'm open to ideas. Thanks!Your maturin version (
maturin --version
)1.4.0
Your Python version (
python -V
)3.10.12
Your pip version (
pip -V
)22.0.2
What bindings you're using
pyo3
Does
cargo build
work?If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash
/
)?Steps to Reproduce
This is the log from
maturin sdist -m wheel/Cargo.toml
:Expand output
The text was updated successfully, but these errors were encountered: