Add MPIGradient #89
Merged
Add MPIGradient #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good stuff @rohanbabbar04 :) I have just started reviewing this and will try to give you all my comments in the next few days |
mrava87
reviewed
Mar 27, 2024
There was a problem hiding this comment.
@rohanbabbar04, this looks great :) I just pushed some minor changes and left a comment for you but i think this is very close to be ready to merge. Good job!
|
Sure @mrava87 I have done the changes, if it looks good you can merge this... |
|
Great @rohanbabbar04, I am merging this. Btw, feel free to go ahead and prepare a release :) otherwise, I can try to do so in coming weeks when I have some time... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #62
matvecandrmatvecin StackedLinearOperator.MPIGradienttest_derivative.pyplot_derivative.pyindex.rstand added MPIGradient inbasicoperators/__init__.py