Interface changes too often for no reason, please keep more backwards compatibility. #1671
Replies: 1 comment 4 replies
-
The advantage? Well, besides making the code more Pythonic and consistent with PEP 8 (you know, that style guide thing that everyone uses), it provides better type safety and more explicit access to the underlying value. The .value part isn't just there to make your fingers do extra typing - it makes it crystal clear when you're working with the enum member versus its raw value. Addressing the case, I prefer snake_case over SCREAM_CASE.(mutation is scary, not constants). If you're worried about breaking changes, ..that's kind of the point of major version updates. They're perfect opportunities to fix historical inconsistencies and modernize interfaces. Would you rather we kept all the legacy quirks forever, just for nostalgia's sake? |
Beta Was this translation helpful? Give feedback.
-
IMPORTANT: Be sure to replace all template sections {{ like this }} or your issue may be discarded.
Desired Behavior
{{ A description of how you think PyAV should behave. }}
I don't see why changing Flags.FAST_SEEK should change to Flags.fast_seek.value what is the advantage here ? Is there a real reason to change this interface!?
Additional context
Breaking changes.
{{ Add any other context about the problem here. }}
Beta Was this translation helpful? Give feedback.
All reactions