-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dupe, doubble click and shift click #577
Conversation
Does this fix any issues ?, Maybe #547 |
Yep, it fixes that issue |
I notice that our currently implementation has a bug which disallows the player to interact with an item the first time they open there Inventory. Can you may fix this as well? |
Ye that's odd, but that was a bug before I think cause even logging all clickevents it won't show the first interaction |
That issue is caused because the state id is off sync |
I fixed so it works first try now, and I also added partial support for equipping armor with shift clicking |
Nice, It fixed now. Great job @4lve. So i have one last bug i would love to have fixed 😅. Maybe you noticed that when you begin to drag an item in inventory and then close the inventory while having the stack dragged, it is not reseted but still being dragged when open the inventory the next time |
@Snowiiii Thx, I could maybe fix that in another PR |
Hey @4lve I made a review, should be good to merge after. The item dragging can be another PR. Could you help me understand what the state_id does? At the end there was something weird with |
Idk, I just found that the state id decreases by 2 after closing a container. Found it by trail and error |
I broke something... |
Sorry @4lve I tried to push to your PR but something got messed up. Could you merge my PR to your fork and then re-open the PR? Your authorship should be retained. Thanks for working on this! |
Description
This PR fixes:
Testing
Please follow our Coding Guidelines