Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Splash Potion Implementation #523

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Initial Splash Potion Implementation #523

wants to merge 8 commits into from

Conversation

OfficialKris
Copy link
Contributor

@OfficialKris OfficialKris commented Jan 31, 2025 •
edited
Loading

Description

Splash potions!

Implements the structures to allow potions in inventory, use, and broadcast to other players. No effects from various types of potions in this PR.

Testing

  • 2 clients
  • add splash potion to inventory
  • use splash potion
  • see correct behavior in both clients

TODO:

  • use entity tick system
  • potion effect and entity follow calculated trajectory
  • player collisions!
  • gravity on server
  • calculate block collision
  • potion splash and entity color match potion used

Maybe there can be a debug mode so we can compare client/server calculation of trajectory?

Snowiiii
Snowiiii reviewed Jan 31, 2025
View reviewed changes
@OfficialKris OfficialKris marked this pull request as ready for review February 22, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snowiiii Snowiiii Snowiiii left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OfficialKris @Snowiiii