Bug/ios icloud not syncing #2395
Open
+1,708
−525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nc to find undownloaded files and download them and send a notification so roms can be imported
…ded; fixed wrong notification observing
…on crash that occurs when realm is being used by the different iCloud syncing that causes the crash
…g convention; removed importing from app delegate; added TODOs
…s when saving save states on realm
…ith iCloud due to realm
…shes downloading insetad of checking in a loop; updated to import only roms and just download any extra files that are part of the ROMs directory for each core; updated to make the syncers live for the lifetime of the application; added concurrency for downloading files to speed things up; refactored saved states code to just work directly with downloaded files; removed unused events
pabloarista
force-pushed
the
bug/ios-icloud-not-syncing
branch
from
0baab55 to
f1fa3fe
Compare
…ync; removed processingfiles for roms; updated to clear successful imports; updated to set multi file roms based on system;
…1 at a time to reduce memory usage
… after the ROMs db finishes initializing.
…nitialized; removed queue with cache status and new cases no longer needed; updated removeFromiCloud to print result; updated transactions to use asyncWrite; refactored deletion code into actor; put back loadAllFromICloud on ROM syncer to reload game cache; added a single call to RomDatabase.reloadGamesCache() iff a single game was deleted; removed DispatchQueue on game importer start processing
…tore; removed enum cases no longer needed;
…eck if roms database is already initialized; fixed syntax errors
…i file roms available to import
…ed when app closed not deleting all; fixed crash deleting roms from db; added condition on adding a segacd rom
…ed text; updated logic for when a file finishes downloading and does not exist to add a warning, but continue flow (happened on ipad pro 12.9" 1st gen); added trying to migrate a save state from 2.x to 3.x;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Where should the reviewer start
How should this be manually tested
Any background context you want to provide
What are the relevant tickets
Screenshots (important for UI changes)
Questions