Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

GUI: animation breaks for unnamed animations #205

Open
daose opened this issue Feb 26, 2020 · 1 comment
Open

GUI: animation breaks for unnamed animations #205

daose opened this issue Feb 26, 2020 · 1 comment
Labels
Area: User Interface Issues related to the spritec GUI

Comments

@daose
Copy link
Contributor

daose commented Feb 26, 2020

Two issues:

  1. UI side is using three.js animation names (which will convert missing names into animation_0 that spritec doesn't understand)

Need to read .load(...).parser.json.animations[i].name instead of .load(...).animations[i].name

  1. spritec binding assumes that a None for animation name means we don't want animations, but it could be that we just want to use the unnamed animation instead (which spritec does support, although not sure if they support choosing between 2 unnamed animation)

Need to widen granularity from animation.name to animation itself that could be null and handle it in spritec_binding. This will allow animation to contain animation.name which is null.

@daose daose added the Area: User Interface Issues related to the spritec GUI label Feb 26, 2020
@sunjay
Copy link
Contributor

sunjay commented Feb 26, 2020

We do not currently support choosing between two unnamed animations (cc @JLSJamesShi). The reasoning being that we don't know how someone would want to select between them if they don't have a name. Also, we'd really rather them just name their animations rather than add support for that.

spritec binding assumes that a None for animation name means we don't want animations

Maybe you could represent this with an empty string instead?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: User Interface Issues related to the spritec GUI
Projects
None yet
Development

No branches or pull requests

2 participants