Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/issue 58 replace logo in the header with svg #62

Merged
merged 2 commits into from
Jun 20, 2024
Merged

enhancement/issue 58 replace logo in the header with svg #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a869e0b
replace logo in the header with svg
spudoodle Jun 18, 2024
f5e6477
change testcase
spudoodle Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/header/header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import discordIcon from "../../assets/discord.svg?type=raw";
import githubIcon from "../../assets/github.svg?type=raw";
import twitterIcon from "../../assets/twitter-logo.svg?type=raw";
import mobileMenuIcon from "../../assets/tile.svg?type=raw";
import greenwoodLogo from "../../assets/greenwood-logo.svg?type=raw";

export default class Header extends HTMLElement {
constructor() {
Expand All @@ -16,7 +17,7 @@ export default class Header extends HTMLElement {
this.shadowRoot.innerHTML = `
<header>
<div class="logo-bar">
<img class="greenwood-logo" src="/assets/greenwood-logo.svg" alt="Greenwood Logo">
${greenwoodLogo}
</div>

<nav class="nav-bar">
Expand Down
2 changes: 1 addition & 1 deletion src/components/header/header.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe("Components/Header", () => {
});

it("should have the Greenwood logo", () => {
const logo = header.shadowRoot.querySelectorAll("img[alt='Greenwood Logo'");
const logo = header.shadowRoot.querySelectorAll(".logo-bar svg");

expect(logo.length).equal(1);
expect(logo[0]).not.equal(undefined);
Expand Down
Loading