Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/issue 32 shared layout for all pages #56

Merged
merged 5 commits into from
Jun 13, 2024
Merged

feature/issue 32 shared layout for all pages #56

merged 5 commits into from
Jun 13, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jun 6, 2024 •
edited
Loading

Related Issue

resolves #32

Summary of Changes

  1. Created a src/templates/app.html and <page-outlet></page-outlet>
  2. Incorporated theme.css for all design system branding (and dropped main.css)
  3. Incorporated <app-header> component
  4. Ported / tweaked all <meta> tags from the current website
  5. Add prism syntax highlighting with basic home page example
  6. Added fonts bundle from OpenProps since it was actually being used in the header

@thescientist13 thescientist13 added the enhancement New feature or request label Jun 6, 2024
@thescientist13 thescientist13 force-pushed the feature/issue-32-shared-layout branch from b3e4144 to 190cea6 Compare June 6, 2024 15:31
@netlify Netlify
Copy link

netlify bot commented Jun 6, 2024

✅ Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit b3e4144
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/6661d62e599bf40009cf09ee
😎 Deploy Preview https://deploy-preview-56--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jun 6, 2024 •
edited
Loading

✅ Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit a2db51d
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/666772a56cac5b0008555cd5
😎 Deploy Preview https://deploy-preview-56--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

thescientist13
thescientist13 commented Jun 10, 2024
View reviewed changes
Copy link
Member Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I should probably set up the syntax highlighting for the project as well.

@thescientist13 thescientist13 changed the base branch from main to bundle-static-css-assets June 10, 2024 21:34
@thescientist13 thescientist13 changed the base branch from bundle-static-css-assets to main June 10, 2024 21:34
@thescientist13 thescientist13 merged commit 0148fce into main Jun 13, 2024
5 checks passed
@thescientist13 thescientist13 deleted the feature/issue-32-shared-layout branch June 13, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create a shared layout for all pages
1 participant
@thescientist13