handle require.resolve fallback when walking node_modules with no main field in package.json #733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #557 (comment)
Summary of Changes
require.resolve
can find what we needTODOs
main
field in its package.json (see edit to above linked comment)"main"
orexports
, in the case of @babel/runtime, they still have their owndependencies
, so we still need to get the location to walk that package.jsonimport.meta.resolve
to support import maps generation and accurate node_modules resolution when building #684 or keep leverage NodeJS resolve logic for looking up location of paths for node modules #557 open and move into the next project?require.resolve.paths
should be a good fallback ifrequire.resolve
itself fails.