Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/issue 1317 import map generation refactor for exports and leveraging import.meta.resolve #1326

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
65d5aeb
walker package ranger import map refactoring
thescientist13 Nov 16, 2024
c93c378
handling export patterns and Spectrum Action Menu behaviors working
thescientist13 Nov 19, 2024
086cde2
spectrum styles working
thescientist13 Nov 19, 2024
53423f6
AWS SDK example
thescientist13 Nov 20, 2024
b366dd6
re-using import.meta.resolve in more places
thescientist13 Nov 21, 2024
279a976
rollback polyfill plugin refactoring
thescientist13 Nov 25, 2024
de6e37d
handle deriving root directory of an import.meta.resolve
thescientist13 Nov 25, 2024
7a59b2c
css linting
thescientist13 Nov 25, 2024
5e0f67f
handle conditionals for . exports condition using redux
thescientist13 Nov 26, 2024
b464293
remove dependency on rollup replace plugin
thescientist13 Nov 26, 2024
4ba3dc8
WIP of export map patterns refactoring
thescientist13 Nov 26, 2024
4137db2
nested export patterns support
thescientist13 Nov 27, 2024
4beefe9
restore test dependency
thescientist13 Nov 27, 2024
d6a44a7
improved support for deeply nested wildcard subpath patterns
thescientist13 Nov 27, 2024
3ece01f
comments
thescientist13 Nov 27, 2024
22a8da9
disable puppeteer
thescientist13 Nov 27, 2024
5ac876f
validating a bare specifier can be loaded from an import attribute us…
thescientist13 Nov 27, 2024
cee243c
CSS @import testing
thescientist13 Nov 27, 2024
99d3cb8
update import map snapshot test cases with wider range of export maps…
thescientist13 Nov 27, 2024
70c2681
bare specifier import attribute test cases
thescientist13 Nov 27, 2024
139e0c7
clean up test cases for not having to copy node modules files
thescientist13 Nov 27, 2024
858f63a
revert node version for the project
thescientist13 Nov 28, 2024
6f3db69
import map generation fixes for different sub and subValue patterns
thescientist13 Nov 28, 2024
55e6276
cutover to new version of walker package ranger
thescientist13 Nov 28, 2024
86f9c3c
diagnostics tracking and logging
thescientist13 Nov 28, 2024
0a31c98
misc comments tweaks
thescientist13 Nov 28, 2024
652d823
acorn options rename
thescientist13 Dec 1, 2024
00efac7
remove demo code
thescientist13 Dec 2, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@
"lint:css": "stylelint \"./www/**/*.js\", \"./www/**/*.css\"",
"lint": "ls-lint && yarn lint:js && yarn lint:css"
},
"resolutions": {
"lit": "^3.1.0"
},
"devDependencies": {
"@babel/core": "^7.24.4",
"@babel/eslint-parser": "^7.24.1",
Expand Down
15 changes: 6 additions & 9 deletions packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
"dependencies": {
"@rollup/plugin-commonjs": "^28.0.0",
"@rollup/plugin-node-resolve": "^15.0.0",
"@rollup/plugin-replace": "^5.0.5",
"@rollup/plugin-terser": "^0.4.4",
"acorn": "^8.14.0",
"acorn-walk": "^8.3.4",
Expand All @@ -57,21 +56,19 @@
"wc-compiler": "~0.15.1"
},
"devDependencies": {
"@babel/runtime": "^7.10.4",
"@lion/button": "^0.14.5",
"@lion/calendar": "^0.16.7",
"@mapbox/rehype-prism": "^0.5.0",
"@material/mwc-button": "^0.25.2",
"@stencil/core": "^2.12.0",
"@types/trusted-types": "^2.0.2",
"@shoelace-style/shoelace": "^2.18.0",
"@spectrum-css/card": "^9.3.0",
"@spectrum-web-components/action-menu": "^1.0.1",
"@uswds/web-components": "^0.0.1-alpha",
"geist": "^1.2.0",
"lit": "^3.1.0",
"lit-redux-router": "~0.20.0",
"lodash-es": "^4.17.20",
"postcss-nested": "^4.1.2",
"pwa-helpers": "^0.9.1",
"redux": "^4.0.5",
"redux-thunk": "^2.3.0",
"redux": "^5.0.1",
"redux-thunk": "^3.1.0",
"rehype-autolink-headings": "^4.0.0",
"rehype-slug": "^3.0.0",
"simpledotcss": "^1.0.0"
Expand Down
6 changes: 4 additions & 2 deletions packages/cli/src/lib/node-modules-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
import { checkResourceExists } from './resource-utils.js';
import fs from 'fs/promises';

// TODO delete me and everything else in this file

Check warning on line 5 in packages/cli/src/lib/node-modules-utils.js

View workflow job for this annotation

GitHub Actions / build (18)

Unexpected 'todo' comment: 'TODO delete me and everything else in...'

Check warning on line 5 in packages/cli/src/lib/node-modules-utils.js

View workflow job for this annotation

GitHub Actions / build (18)

Unexpected ' TODO' comment: 'TODO delete me and everything else in...'

Check warning on line 5 in packages/cli/src/lib/node-modules-utils.js

View workflow job for this annotation

GitHub Actions / build (18)

Unexpected 'todo' comment: 'TODO delete me and everything else in...'

Check warning on line 5 in packages/cli/src/lib/node-modules-utils.js

View workflow job for this annotation

GitHub Actions / build (18)

Unexpected ' TODO' comment: 'TODO delete me and everything else in...'
// https://github.com/ProjectEvergreen/greenwood/issues/684
async function getNodeModulesLocationForPackage(packageName) {
let nodeModulesUrl;

Expand Down Expand Up @@ -42,7 +44,7 @@
return packageName;
}

async function getPackageJson({ userWorkspace, projectDirectory }) {
async function getPackageJsonForProject({ userWorkspace, projectDirectory }) {
const monorepoPackageJsonUrl = new URL('./package.json', userWorkspace);
const topLevelPackageJsonUrl = new URL('./package.json', projectDirectory);
const hasMonorepoPackageJson = await checkResourceExists(monorepoPackageJsonUrl);
Expand All @@ -56,7 +58,7 @@
}

export {
getPackageJsonForProject,
getNodeModulesLocationForPackage,
getPackageJson,
getPackageNameFromUrl
};
4 changes: 2 additions & 2 deletions packages/cli/src/lib/parsing-utils.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
const acornOptions = {
const ACORN_OPTIONS = {
ecmaVersion: 'latest',
sourceType: 'module'
};

export {
acornOptions
ACORN_OPTIONS
};
Loading
Loading