Pass hyper params from client #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liam-sbhoo
reviewed
May 6, 2024
There was a problem hiding this comment.
Looking great in overall!
Just some comments/questions:
- regarding the model args, why not pop the
modelargs in the client instead and keep the server untouched? Then we'll have one less change to make when we have the feature enabled. - can we add some test cases, concerning the presence of
tabpfn_config? Just a very minimal safe guard to ensure that we taketabpfn_config
|
Tests: yeah, good point. I will add a test ensuring the defaults are send. "model" arg: at some point we will need this model arg anyways, as we will train new models and want users to be able to choose, so I thought why not now. I should make it backward compatible on the backend, though. |
|
i added a test and updated it to follow the new API. Can I merge @liam-sbhoo ? |
liam-sbhoo
reviewed
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Brief (a few bullet points describing your changes, use full sentences and try to link lines in the code whenever needed)
In this PR, I start passing all arguments to the server. To make this simpler I removed the local tabpfn functionality for now but kept the main code s.t. we can easily re-enable it later on. This was simpler, because the local tabpfn has very different parameters from the server one.
DEPENDENCY: this PR depends on https://github.com/automl/tabpfn-server/pull/48/ to filter out the "model" kwarg
Standard Qs (leave questions that do not apply blank)
If you broke behavior: Please describe what behavior you broke and how you inform people to not get stuck trying to use the old behavior.
yes, i removed local
If you used new dependencies: Did you add them to
requirements.txt?no
Who did you ping on Mattermost to review your PR? Please ping that person again whenever you are ready for another review.
@liam-sbhoo @anshulg954 @davidotte
Please do not mark comments/conversations as resolved unless you are the assigned reviewer. This helps maintain clarity during the review process.