Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select] - Global refactoring #384

Closed
mattgoud opened this issue Oct 10, 2024 · 0 comments · Fixed by #394
Closed

[Select] - Global refactoring #384

mattgoud opened this issue Oct 10, 2024 · 0 comments · Fixed by #394
Assignees
@mattgoud
Labels
accessibility breaking change bug Something isn't working Feature Type: New Feature refactoring

Comments

@mattgoud
Copy link
Collaborator

Description

⚠️ Breaking changes : Refactoring of the existing Select component

Tasks
@mattgoud mattgoud added Feature Type: New Feature bug Something isn't working refactoring breaking change accessibility labels Oct 10, 2024
@mattgoud mattgoud self-assigned this Oct 10, 2024
mattgoud added a commit that referenced this issue Oct 14, 2024
@mattgoud
feat: [Select] - related #384 - global refacto (wip)
35d50b6
mattgoud added a commit that referenced this issue Oct 15, 2024
@mattgoud
feat: [Select] - related #384 - global refacto (style wip)
1db2e5b
mattgoud added a commit that referenced this issue Oct 16, 2024
@mattgoud
feat: [Select] - related #384 - add translations, style(wip), add new…
e9c0083 
… props(disabled feature)
mattgoud added a commit that referenced this issue Oct 16, 2024
@mattgoud
feat: [Select] - related #384 - initialize selectedOptions with model…
7a31706 
…Value prop
mattgoud added a commit that referenced this issue Oct 17, 2024
@mattgoud
feat: [Select] - related #384 - change puik-option logic (select even…
97d236f 
…t), fix weird behavior of selectAll feature (handle disabled options case)
mattgoud added a commit that referenced this issue Oct 17, 2024
@mattgoud
feat: [Select] - related #384 - separate v-model refs between single …
2244ca4 
…and multi select (selectedSingleOption/selectedMultipleOptions), style puik-select
mattgoud added a commit that referenced this issue Oct 18, 2024
@mattgoud
feat: [Select] - related #384 - implement puik-option via slot
bb50b56
mattgoud added a commit that referenced this issue Oct 19, 2024
@mattgoud
feat: [Select] - related #384 -fix puik-option reactivity when using …
ce8102a 
…in slot mode
mattgoud added a commit that referenced this issue Nov 12, 2024
@mattgoud
feat: [refacto-select] #384 - change select payload if option is dese…
193e308 
…lected
mattgoud added a commit that referenced this issue Nov 12, 2024
@mattgoud
feat: [refacto-select] #384 - add close event (option) and open event…
7a99358 
… (select)
mattgoud added a commit that referenced this issue Nov 13, 2024
@mattgoud
feat: [refacto-select] #384 - create puik-group-options component, fi…
b9c74d8 
…x translations
mattgoud added a commit that referenced this issue Nov 14, 2024
@mattgoud
feat: [refacto-select] #384 - improve accessibility, keyboard handlin…
3461d27 
…g (wip), add select label and error
mattgoud added a commit that referenced this issue Nov 15, 2024
@mattgoud
feat: [select] - related #384 - form case to send data : add value in…
07e8145 
… hidden inputs
mattgoud added a commit that referenced this issue Nov 18, 2024
@mattgoud
feat: [selet-refacto] - related #384 - improve searcheable feature (f…
bc9d181 
…ilteredOptions with custom method, filtering by optionLabelKey instead default label)
mattgoud added a commit that referenced this issue Nov 20, 2024
@mattgoud
feat: [select-refacto] - related #384 - fix style error input, improv…
301ab81 
…e keyboard handling (esc to close dropdown), fix reset search query feature when dropdown is closed
mattgoud added a commit that referenced this issue Nov 21, 2024
@mattgoud
feat: [select-refacto] - related #384 - improve accessiblity (ARIA ta…
2a9aebe 
…gs), add zIndex prop (group-options), styling focus on error puik-input-wrapper
mattgoud added a commit that referenced this issue Nov 21, 2024
@mattgoud
feat: [select-refacto] - related #384 - keyboard Handling (wip)
0f20fa3
mattgoud added a commit that referenced this issue Nov 21, 2024
@mattgoud
feat: [select-refacto] - related #384 - fix keyboard and mouse confli…
2af8313 
…ct behavior on selectAll handling
mattgoud added a commit that referenced this issue Nov 22, 2024
@mattgoud
feat: [select-refacto] - related #384 - fix toggleSelectAll feature f…
40d743a 
…or disabled options cases
mattgoud added a commit that referenced this issue Nov 23, 2024
@mattgoud
feat: [select-refacto] - related #384 - close dropdown on tab keydown
0e1f032
@mattgoud mattgoud linked a pull request Dec 17, 2024 that will close this issue
Feat/384 select global refactoring #394
Merged
9 tasks
@mattgoud mattgoud mentioned this issue Dec 17, 2024
Merged
9 tasks
mattgoud added a commit that referenced this issue Dec 18, 2024
@mattgoud
feat: [refacto-select] - related #384 : delete useless PuikGroupOptio…
a9a31f2 
…ns component
mattgoud added a commit that referenced this issue Dec 18, 2024
@mattgoud
feat: [refacto-select] - related #384 : add z-index prop (on dropdown…
69c105a 
… select) and update story and test accordingly
mattgoud added a commit that referenced this issue Jan 15, 2025
@mattgoud
feat: [useSnackbar] - related #384 - fix data-test name of pagination…
cb00bdc 
… jumper select
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattgoud mattgoud

Labels
accessibility breaking change bug Something isn't working Feature Type: New Feature refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/384 select global refactoring PrestaShopCorp/puik
1 participant
@mattgoud