Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Enable video upload #114

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

agentpietrucha
Copy link

Questions Answers
Description? Enable uploading videos for the image slider. File type checks were updated as well as new poster column is added to the database to store the video poster filename
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket?
Sponsor company
How to test? Upload .mp4 files. Disable theme overwrite of slider.tpl file so the default module one will be used

@ps-jarvis
Copy link

Hello @agentpietrucha!

This is your first pull request on ps_imageslider repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@agentpietrucha agentpietrucha changed the title Dev Feature: Enable video upload Jan 2, 2025
@ps-jarvis
Copy link

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

  • Modules.Imageslider.Admin
    • Unsupported file extension: %extension%
    • Failed to process the file
    • Unsupported file type: %file_type%

(Note: this is an automated message, but answering it will reach a real human)

@agentpietrucha
Copy link
Author

@Hlavtox
I created a new PR, since the old one was targeting the wrong branch on my fork. You left the following comment there:

I think it's too complicated. If something, I would enable people to upload properly formatted MP4 or WEBM. Everyone have different needs for quality and file size.

Also, please remove the change of author.

✅ Authors fixed
Could you please elaborate more about why it is too complicated please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

4 participants