Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.2.1 #111

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Release 3.2.1 #111

merged 5 commits into from
Sep 25, 2024

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Sep 25, 2024

Questions Answers
Description? Release 3.2.1
Type?
BC breaks?
Deprecations?
Fixed ticket?
Sponsor company
How to test?

@ShaiMagal
Copy link
Contributor

Merging as it was tested here #110 and there was only one change.

@ShaiMagal ShaiMagal merged commit 420b175 into master Sep 25, 2024
18 checks passed
@ps-jarvis
Copy link

PR merged, well done!

Message to @PrestaShop/committers: do not forget to milestone it before the merge.

@ShaiMagal ShaiMagal added this to the 3.2.1 milestone Sep 25, 2024
@kpodemski
Copy link
Contributor

hello @ShaiMagal

it's QA decision to make, not yours

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Sep 25, 2024

@kpodemski I discussed this with @florine2623 and she tested the PR few hours ago.

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Sep 25, 2024

@kpodemski

  • I did the last PR Use AdminController #96 and missed an issue that somebody else made.
  • I released 3.2.0
  • I fixed it here and florine properly tested it. Including upgrade. Also, Dominik tested it. Also the person who reported the issue tested it. Works fine.
  • I made this release PR with the ONLY ONE change and I asked Dominik to merge it, so we can deliver the fix.

Am I wrong here?

@kpodemski
Copy link
Contributor

Hi @Hlavtox

In that case it's all clear, it should be written in the merge message or @florine2623 could put QA Approved label

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Sep 25, 2024

@kpodemski OK, I will make sure to note it for the police next time 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants