Show all slides in back office #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kpodemski
commented
Jun 13, 2024
kpodemski
commented
| Questions | Answers |
|---|---|
| Description? | In back office we should show all slides, even those without images |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#35704 |
| Sponsor company | Your company or customer's name goes here (if applicable). |
| How to test? | Follow instructions from the issue. |
2 tasks
boherm
approved these changes
Jun 13, 2024
florine2623
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Hello @kpodemski ,
Tested on develop with classic and hummingbird ✅
The sliders are well displayed in the BO and the FO.
Screen.Recording.2024-06-13.at.16.28.14.mov
Tested on 8.1.7 with classic theme.
I am encountering some issues. The slider is displayed in the BO, but when I view my store, I can't see it. I have tried clearing cache from PS and from browser.
Screen.Recording.2024-06-13.at.16.30.34.mov
Could you check please ?
Thanks!
|
@florine2623 change the language, if you don't add an image for w given language, slide is hidden not to show broken image |
florine2623
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Hello @kpodemski ,
Yes you are right ^^
Tested on single shop and multistore. The slides are well displayed in the BO configuration page.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.